[RFC] Store patch authors in the new Patch.author field

Mauro Carvalho Chehab mchehab at redhat.com
Fri Apr 29 23:35:58 EST 2011


Em 29-04-2011 00:09, Jeremy Kerr escreveu:
> Hi Mauro,
> 
>>> For ubuntu-kernel, when proposing an update patch, we forward the entire
>>> commit (possibly with comments before it, like why we're proposing the
>>> patch for that ubuntu kernel version). In this case, it'd be correct to
>>> parse the *last* From: line before the patch itself.
>>
>> This will do the wrong thing on several cases where someone keeps a From: message
>> from a comment received during the patch discussions. There are several cases
>> where this happens.
> 
> Sorry, not sure I understand this - you mean someone is sending a patch,
> but includes an un-quoted 'From:' line from existing discussion?

Yes.

> Could
> you point me to an example?

I don't have any example right now, as 99% of the patches I receive just have one
From: at the email headers. The remaining ones have a mix of the From: at the beginning
of the body (meaning the patch author) and From: or Subject: in the middle of the patch
used, for example, to point (or reply) to someone's email or to a patch that needs to
be reverted due to some problem.

The only case where I have a From: indicating patch author outside the first line in
body is when akpm sends me some patches from LKML that I might have missed, with a syntax
close to "forward". My import script have an special rule to handle the "forward" special 
case. I don't think such special-case rules should be inside patchwork core. If someone
needs it, it should be done via some pwclient or external scripts at the XMLRPC client machine.

Mauro.


More information about the Patchwork mailing list