[RFC] Store patch authors in the new Patch.author field

Mauro Carvalho Chehab mchehab at redhat.com
Fri Apr 29 12:40:30 EST 2011

Em 28-04-2011 23:10, Jeremy Kerr escreveu:
> Hi Guilherme,
>> When the first line of the email message that contains a patch starts with
>> 'From:' and contain an email address, we use that address as the author;
>> otherwise we use the same as the submitter.
>> Currently this information is not shown anywhere but it could be easily
>> exposed in the UI and or over XML-RPC. I'd be happy to do that if there are no
>> objections to this patch.
> I'd be happy to apply this; the tricky bit will be how to expose this in
> the UI, but we can work that out separately.
> One question though: should we allow From: to be on any line of a patch,
> rather than the first? Consider something like:
>  http://patchwork.ozlabs.org/patch/92959/
> For ubuntu-kernel, when proposing an update patch, we forward the entire
> commit (possibly with comments before it, like why we're proposing the
> patch for that ubuntu kernel version). In this case, it'd be correct to
> parse the *last* From: line before the patch itself.

This will do the wrong thing on several cases where someone keeps a From: message
from a comment received during the patch discussions. There are several cases
where this happens.


More information about the Patchwork mailing list