[PATCH]handle octet-stream attachments that contain patches

Patrick Georgi patrick at georgi-clan.de
Wed Aug 25 01:28:11 EST 2010


attached patch adds handling for octet-stream typed patches, like google
mail sends them.
It relies on parse_patch to determine if the octet-stream is actually a
patch, and I didn't check how robust that is against abuse (eg. binary
data), so that might not be the best approach.

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>

The other issue I'd like to fix (or see fixed preferably :-) ) is that
replies that dissect a patch (by commenting inline) sometimes end up as
new (and invalid) patches on the patchwork queue.
My approach would be to change parse_patch to be somewhat more strict on
the patch format. I didn't look at it yet, but that should fix it.
Is it a design goal to keep reformatted patches (eg. line breaks) alive?
That would break said approach.

Patrick Georgi
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20100824-4-octetstreams-for-patchwork.diff
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20100824/3f5d9250/attachment.ksh>

More information about the Patchwork mailing list