Lack of patch comments history when getting a patch via pwclient

Mauro Carvalho Chehab mchehab at
Thu Apr 22 00:33:18 EST 2010

Again, I got trapped by the lack of the history when getting the patches via pwclient.
On the last recent case, this patch:

Is clearly not ready for merge, when looking via web, but if you get the patch via
pwclient view, it gets:

	Content-Type: text/plain; charset="utf-8"
	MIME-Version: 1.0
	Content-Transfer-Encoding: 7bit
	Subject: Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices
	Date: Sun, 11 Apr 2010 09:12:52 -0000
	From: Klaus Schmidinger <Klaus.Schmidinger at>
	X-Patchwork-Id: 91888
	Message-Id: <4BC19294.4010200 at>
	To: linux-media at

	The enum fe_caps provides flags that allow an application to detect
	whether a device is capable of handling various modulation types etc.
	A flag for detecting PSK_8, however, is missing.
	This patch adds the flag FE_CAN_PSK_8 to frontend.h and implements
	it for the gp8psk-fe.c and cx24116.c driver (apparently the only ones
	with PSK_8). Only the gp8psk-fe.c has been explicitly tested, though.

	Signed-off-by: Klaus Schmidinger <Klaus.Schmidinger at>
	Tested-by: Derek Kelly <user.vdr at>
	Acked-by: Manu Abraham <manu at>

	To unsubscribe from this list: send the line "unsubscribe linux-media" in
	the body of a message to majordomo at
	More majordomo info at

So, based on the presented "history", the patch looked sane and ready for merging.

"pwclient get" also doesn't help, as it keep removing the patch discussions.

It would be really nice and important to avoid mistakes, if "pwclient view" xml implementation could provide
not only the patch plus the acks, but also the comments that the patch may have received. Something like:

	<patch description>



	<comments from the others, if there are any>

This way, we avoid the need of going to the patch history and to the ML for every single patch
that patchwork catches, just to double check if the patch actually got nacked or are just a RFC.



More information about the Patchwork mailing list