State diagram of patch status, possible bug in apps/patchwork/utils.py

[Carl-Daniel Hailfinger]

Hi,

we're trying to use patchwork for the flashrom project (see
http://www.coreboot.org/Flashrom and
http://patchwork.coreboot.org/project/flashrom/ ) and there are some
obstacles which got in the way. I'll list them here in the hope you can
either fix them or tell me where to RTFM.

1. I could not find any documentation for patchwork, neither online nor
in the downloaded source code.

2. What's the expected or recomended patch lifecycle status diagram?
Will "Under review" automatically appear once the first Acked-by comment
happens? Having to extract logic from the application code is less than
ideal.

3. apps/patchwork/models.py line 291 looks for the following regexp:
'^([Tt]ested|[Rr]eviewed|[Aa]cked|[Ss]igned-off|[Nn]acked)-by: .*$'
That regexp won't catch oddbal capitalizations like Signed-Off-by unless
I'm mistaken.

4. apps/patchwork/templatetags/syntax.py line 41ff is missing Nacked-by.

5. How can I automatically match commits against pending patches? We use
one centralized subversion repository and the mailing list gets a commit
mail for every commit. If matching committed patches automatically
against pending patches is not possible, can we have patchwork parse
replies to patches which usually say something like "...comitted in
r1234" or "thanks, r1234"?

6. Some parts of patchwork seem to hardcode git usage. Is that just
because nobody had the time to add subversion support as well?

7. Possible bug in the unarchive action in apps/patchwork/utils.py,
patch follows:

diff --git a/apps/patchwork/utils.py b/apps/patchwork/utils.py
index 797951c..fa26aef 100644
--- a/apps/patchwork/utils.py
+++ b/apps/patchwork/utils.py
@@ -183,7 +183,7 @@ def set_patches(user, project, action, data, patches, context):
             str = 'archived'
 
         elif action == 'unarchive':
-            patch.archived = True
+            patch.archived = False
             patch.save()
             str = 'un-archived'
 

Regards,
Carl-Daniel