Fw: [kernel.org users] [KORG] Announcement: patchwork.kernel.org

[Mauro Carvalho Chehab]

Hi JH,

I've sent two fixes for patchwork to Jeremy some time ago, but it seems that he
didn't apply yet on his tree. The first one (utf_fix.patch) fixes a serious bug
when using patchwork with XMLRPC interface: if one of the messages has any
accent at the name of the patch author (or at the subject and other headers),
xmlrpc stops working (it returns an empty set of patches).

I'm currently facing this trouble with linux-media, at patchwork.kernel.org:

$ pwclient list -p linux-media 
ID    State        Name
--    -----        ----
$

The second one adds the other review meta-tags to patchwork handling
(Tested-by, Reviewed-by), being also very helpful for upstream handling. 

Could you please apply those patches (enclosed) at patchwork.kernel.org? I have
a long series of patches to apply just waiting for a fix.

Thanks,
Mauro.

Forwarded message:

Date: Tue, 6 Jan 2009 02:06:08 -0200
From: Mauro Carvalho Chehab <mchehab at infradead.org>
To: Jeremy Kerr <jk at ozlabs.org>
Subject: Re: [kernel.org users] [KORG] Announcement: patchwork.kernel.org


On Tue, 6 Jan 2009 12:41:58 +0900
Jeremy Kerr <jk at ozlabs.org> wrote:

> Hi Mauro,
> 
> > At the last time we've discussed, you said you saw some issues, but I
> > don't remember you pointing me what were the issues ;)
> 
> I think the main problem is one you pointed out to me - that some 
> patches cause the client to die (a character set problem?).

This were already solved, at least on my tree. The issue were not the client
dying, but the XMLRPC server were returning a NULL set of patches, if one of
the patches had an accented name. The current version (the one that I've added
at the kernel.org) seems very stable. Of course, there are spaces for
improvements.

I think I've sent you the fix already. Maybe you lost that email. Anyway, I'm
enclosing the patch fixing the xmlrpc server.

I'm also enclosing a second patch that seems interesting: It adds some other
meta-tags that sometimes people used (reviewed-by, tested-by). Hmm... maybe we
should also add CC: tag there... It is sometimes useful to keep the CC tag at
the commits.

> > Please point those to me and I'll fix. Or, if you prefer, merge it
> > and add your fixing patches. As I said, I'm far from a python expert.
> 
> OK, I'm happy to work on the changes, I'll take a look this week.

Thanks!


Cheers,
Mauro




Cheers,
Mauro
-------------- next part --------------
A non-text attachment was scrubbed...
Name: utf_fix.patch
Type: text/x-patch
Size: 1726 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20090214/bfca3659/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: new_tags.patch
Type: text/x-patch
Size: 1371 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20090214/bfca3659/attachment-0001.bin>