[OpenPower-Firmware] NVDIMM support

[Artem Senichev]

Hi Oliver,

Could you help me with NVDIMM support in OpenPOWER?

I found your commit to skiboot:
4822a7ba9 hdata/memory: Add NVDIMM support
https://github.com/open-power/skiboot/commit/4822a7ba9d33468a15d1c90ee8c0823826d33320

You added a new field to HDIF_ms_area_address_range structure - phys_attr,
its value defines the type and state of the memory, but I can't find
corresponded code in Hostboot, the hdatMsAreaAddrRange_t structure from HB
doesn't contain these attributes.

Skiboot (HDIF_ms_area_address_range):
https://github.com/open-power/skiboot/blob/80fd2e963bd4364ee8c3b5a06215d8cbdfe04fcb/hdata/memory.c#L31
Hostboot (hdatMsAreaAddrRange_t):
https://github.com/open-power/hostboot/blob/f70454687133f8a8b493f44d981ea1673e4ec437/src/usr/hdat/hdatmsarea.H#L132

How are these attributes populated?

P.S. Also, I suppose there is a typo in Skiboot's code:
https://github.com/open-power/skiboot/blob/80fd2e963bd4364ee8c3b5a06215d8cbdfe04fcb/hdata/memory.c#L588
IMHO, there should be a 'greater' condition, not 'greater or equal'.
The current implementation has equal values of `arr->eactsz` and `offset`
(36 bytes), so reading uint32_t from offset 36 looks strange.

-- 
Regards,
Artem Senichev
Software Engineer, YADRO.