[OpenPower-Firmware] hostboot build fails with "error: ‘TARGET_TYPE_DIMM’ was not declared in this scope" (and more)

[Dan Horák]

Hi,

I have started to work on enabling Raptor's Talos in the upstream
op-build after seeing Stewart started to enable Blackbird. But I have a
problem when building hostboot.

The host environment is Fedora 30 on both x86 and ppc64le, op-build
from the master branch, clean "output" directory, whitherspoon config
(but eg. blackbird config fails the same way).

The failure looks like (with verbose build enabled)
...
cd fapi2 && /usr/bin/make --no-builtin-rules --no-builtin-variables CODE_PASS
cd test && /usr/bin/make --no-builtin-rules --no-builtin-variables --no-builtin-rules --no-builtin-variables CODE_PASS
/mnt/dan/op-build/output/host/bin/powerpc64le-buildroot-linux-gnu-g++ -c  -D__HOSTBOOT_MODULE=testfapi2 -DNO_INITIALIZER_LIST -D__FAPI -include config.h -fPIC -Bsymbolic -Bsymbolic-functions -Os -nostdlib -mcpu=power7 -nostdinc -g -mno-vsx -mno-altivec -Werror -Wall -mtraceback=no -pipe -mabi=elfv1 -ffunction-sections -fdata-sections -ffreestanding -mbig-endian -DFAPI2_ENABLE_PLATFORM_GET_TARGET -nostdinc++ -fno-rtti -fno-exceptions -Werror -Wall -fuse-cxa-atexit -std=gnu++14 ../../../../obj/modules/testfapi2/testfapi2.C \
            -o ../../../../obj/modules/testfapi2/testfapi2.o.trace -I../../../../src/include/usr -I../../../../src/include/ -I../../../../obj/genfiles -I../../../../src/import/hwpf/fapi2/include/ -I../../../../src/include/usr/fapi2/ -I../../../../src/usr/fapi2/test/ -I../../../../src/import/chips/p9/utils/ -I../../../../src/import/chips/p9/utils/imageProcs/ -I../../../../src/import/chips/common/utils/imageProcs/ -I../../../../src/import/chips/p9/common/include/ -I../../../../src/import/chips/p9/procedures/hwp/pm/ -I../../../../src/import/chips/p9/procedures/hwp/accessors/ -I../../../../src/include/usr/targeting/common/ -I../../../../src/import/chips/p9/procedures/hwp/ffdc/ -I../../../../obj/genfiles/ -I../../../../src/import/chips/centaur/procedures/hwp/memory/lib/shared/ -I../../../../src/usr/expaccess/ -iquote .
In file included from ../../../../obj/modules/testfapi2/testfapi2.C:18:0:
./../../../../src/usr/fapi2/test/fapiGetMBVpdTest.H:231:19: error: ‘TARGET_TYPE_DIMM’ was not declared in this scope
     fapi2::Target<TARGET_TYPE_DIMM> iv_targ_dimm;
                   ^~~~~~~~~~~~~~~~
./../../../../src/usr/fapi2/test/fapiGetMBVpdTest.H:231:19: note: suggested alternative:
In file included from ../../../../src/include/usr/fapi2/target.H:42:0,
                 from ../../../../src/import/hwpf/fapi2/include/error_info.H:39,
                 from ../../../../src/import/hwpf/fapi2/include/ffdc.H:39,
                 from ../../../../src/import/hwpf/fapi2/include/return_code.H:37,
                 from ../../../../src/include/usr/fapi2/attribute_service.H:40,
                 from ./../../../../src/usr/fapi2/test/fapiGetMBVpdTest.H:29,
                 from ../../../../obj/modules/testfapi2/testfapi2.C:18:
../../../../src/import/hwpf/fapi2/include/target_types.H:54:5: note:   ‘TARGET_TYPE_DIMM’
     TARGET_TYPE_DIMM          = 0x0000000000000002, ///< DIMM type
     ^~~~~~~~~~~~~~~~
In file included from ../../../../obj/modules/testfapi2/testfapi2.C:18:0:
./../../../../src/usr/fapi2/test/fapiGetMBVpdTest.H:231:35: error: template argument 1 is invalid
     fapi2::Target<TARGET_TYPE_DIMM> iv_targ_dimm;
                                   ^
./../../../../src/usr/fapi2/test/fapiGetMBVpdTest.H:232:19: error: ‘TARGET_TYPE_MBA’ was not declared in this scope
     fapi2::Target<TARGET_TYPE_MBA> iv_targ_mba;
...

I suspect there is something wrong the host build environment, because
the upstream CI builds mostly succeed. Does anyone have an idea what
could be wrong?


	Thanks,

		Dan