[PATCH 2/2] mmc: sdhci-of-aspeed: Add ast2700 support
Philipp Zabel
p.zabel at pengutronix.de
Mon Mar 16 20:44:04 AEDT 2026
On Sa, 2026-03-14 at 01:21 +0000, Ryan Chen wrote:
[...]
> >
> > Thanks the guidance.
> > I will update use
> > sdc->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
> > if (IS_ERR(sdc->rst))
> > return dev_err_probe(&pdev->dev, PTR_ERR(sdc->rst),
> > "unable to acquire reset\n");
> >
> Sorry, I review the devm_reset_control_get_optional_exclusive_deasserted
> I will modify with following in probe.
>
> sdc->rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,
> NULL);
> if (IS_ERR(sdc->rst))
> return dev_err_probe(&pdev->dev, PTR_ERR(sdc->rst),
> "unable to acquire reset\n");
>
> And add reset_control_assert(sdc->rst); in remove.
Only do one of those two changes. The devm_..._deasserted() function
will call reset_control_assert() automatically. See:
https://docs.kernel.org/driver-api/reset.html#c.devm_reset_control_get_optional_exclusive_deasserted
regards
Philipp
More information about the openbmc
mailing list