[PATCH 2/3] pinctrl: use more common syntax for compound literals
Bartosz Golaszewski
brgl at bgdev.pl
Thu Sep 25 18:11:52 AEST 2025
On Thu, Sep 25, 2025 at 10:03 AM Geert Uytterhoeven
<geert at linux-m68k.org> wrote:
>
> Hi Bartosz,
>
> On Thu, 25 Sept 2025 at 09:52, Bartosz Golaszewski <brgl at bgdev.pl> wrote:
> > On Thu, Sep 25, 2025 at 9:48 AM Geert Uytterhoeven <geert at linux-m68k.org> wrote:
> > > On Thu, 11 Sept 2025 at 12:02, Bartosz Golaszewski <brgl at bgdev.pl> wrote:
> > > > From: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
> > > >
> > > > The (typeof(foo)) construct is unusual in the kernel, use a more typical
> > > > syntax by explicitly spelling out the type.
> > >
> > > Thanks for your patch, which is now commit da3a88e9656c17a3 ("pinctrl:
> > > use more common syntax for compound literals") in pinctrl/for-next
> > >
> > > > Link: https://lore.kernel.org/all/20250909-gpio-mmio-gpio-conv-part4-v1-13-9f723dc3524a@linaro.org/
>
> This is the origin link to the patch (by you) that started the discussion.
>
> > >
> > > Looks like you (slightly) missed your target. The correct link is:
> > >
> > > Link: https://lore.kernel.org/aMAP9hAWars0T83r@smile.fi.intel.com
>
> This is the link to the comment (by Andy) that questioned the construct.
>
> > >
> > > > Suggested-by: Andy Shevchenko <andriy.shevchenko at intel.com>
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski at linaro.org>
> >
> > This is a link to the discussion with Andy as per Linus Torvalds'
> > recent request to use the Link: tag to point to actually useful
> > information rather than just the patch's origin. Linus Walleij doesn't
> > use b4 so the origin link you'd normally expect to be added
> > automatically is not there at all. That's probably what caused the
> > confusion.
>
> I know ;-)
>
> Given the "Suggested-by: Andy", shouldn't the link point to the email
> with the actual suggestion?
>
Ah, I didn't realize this is what you meant. I wanted to point to the
entire discussion and also this is already in Linus' tree so it's up
to him if he wants to change it.
Bartosz
More information about the openbmc
mailing list