[PATCH v3 01/10] dt-bindings: soc: aspeed: Add ASPEED PCIe Config

Jacky Chou jacky_chou at aspeedtech.com
Tue Sep 2 12:30:44 AEST 2025


Hi Krzysztof,

Thank you for your reply.

> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - aspeed,ast2700-pcie-cfg
> 
> Why this cannot be part of standard syscon binding file?
> 
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    soc0 {
> 
> soc {
> 
> although why do you need it in the first place...
> 
> > +      #address-cells = <2>;
> > +      #size-cells = <1>;
> > +
> > +      syscon at 12c02a00 {
> > +        compatible = "aspeed,ast2700-pcie-cfg", "syscon";
> > +        reg = <0 0x12c02a00 0x80>;
> > +      };
> > +    };
> 
> 

You’re right — this block doesn’t have any SoC-specific properties and
is only used as a regmap provider, so a dedicated binding is not needed.
I’ll drop the YAML and rely on the generic “syscon” binding.

Thanks,
Jacky


More information about the openbmc mailing list