[PATCH] spi: aspeed: Use devm_iounmap() to unmap devm_ioremap() memory

Chin-Ting Kuo chin-ting_kuo at aspeedtech.com
Thu Nov 6 13:53:26 AEDT 2025


Hi Markus,

> -----Original Message-----
> From: Markus Elfring <Markus.Elfring at web.de>
> Sent: Thursday, November 6, 2025 1:44 AM
> Subject: Re: [PATCH] spi: aspeed: Use devm_iounmap() to unmap
> devm_ioremap() memory
> 
> > The AHB IO memory for each chip select is mapped using devm_ioremap(),
> > so it should be unmapped using devm_iounmap() to ensure proper
> > device-managed resource cleanup.
>> 
> * You may occasionally put more than 61 characters into text lines
>   of such a change description.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docume
> ntation/process/submitting-patches.rst?h=v6.18-rc4#n658
> 

The line characters number is 75 instead of 61. Isn't it?

> * Would another imperative wording become helpful for an improved change
> description?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docume
> ntation/process/submitting-patches.rst?h=v6.18-rc4#n94
> 

How about change the description to the below one?

Use devm_iounmap() to unmap memory mapped with devm_ioremap().
This ensures proper cleanup of device-managed resources.

> 
> Regards,
> Markus


More information about the openbmc mailing list