[PATCH] spi: aspeed: Use devm_iounmap() to unmap devm_ioremap() memory
Cédric Le Goater
clg at kaod.org
Wed Nov 5 19:52:42 AEDT 2025
On 11/5/25 09:49, Chin-Ting Kuo wrote:
> The AHB IO memory for each chip select is mapped using
> devm_ioremap(), so it should be unmapped using devm_iounmap()
> to ensure proper device-managed resource cleanup.
>
> Reported-by: kernel test robot <lkp at intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510292356.JnTUBxCl-lkp@intel.com/
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo at aspeedtech.com>
> ---
> drivers/spi/spi-aspeed-smc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
> index e8bd8fe6c4e7..179c47ffbfeb 100644
> --- a/drivers/spi/spi-aspeed-smc.c
> +++ b/drivers/spi/spi-aspeed-smc.c
> @@ -396,7 +396,7 @@ static int aspeed_spi_set_window(struct aspeed_spi *aspi)
>
> for (cs = 0; cs < aspi->data->max_cs; cs++) {
> if (aspi->chips[cs].ahb_base) {
> - iounmap(aspi->chips[cs].ahb_base);
> + devm_iounmap(dev, aspi->chips[cs].ahb_base);
> aspi->chips[cs].ahb_base = NULL;
> }
> }
Reviewed-by: Cédric Le Goater <clg at redhat.com>
Thanks,
C.
More information about the openbmc
mailing list