[PATCH 18/34] mmc: sdhci-of-aspeed: Drop the use of sdhci_pltfm_free()

Andrew Jeffery andrew at codeconstruct.com.au
Wed May 28 10:43:59 AEST 2025


On Mon, 2025-05-26 at 14:06 +0800, Binbin Zhou wrote:
> Since the devm_mmc_alloc_host() helper is already in
> use, 

This doesn't appear to be true? aspeed_sdhci_probe() calls
sdhci_pltfm_init(), and following that through eventually we call
mmc_alloc_host() (the non-devm_ variant).

That said, there are some error paths in aspeed_sdhci_probe() where we
leak the object. Improving the code would be helpful, but my
understanding is this patch isn't right.

Andrew


More information about the openbmc mailing list