[PATCH u-boot v1] ARM: dts: aspeed: Adjust Device Nodes For Nvidia's GB200NVL BMC

Andrew Jeffery andrew at codeconstruct.com.au
Fri May 16 11:40:53 AEST 2025


Hi Willie

On Thu, 2025-05-15 at 06:56 +0000, Willie Thai wrote:
> Remove unnecessary mdio0 and mac0 for the latest version of hardware.
> Enable HACE and ACRY engine.

Generally I'd ask that you separate these concerns into separate
patches. Given I have another comment below, can you please do so when
you re-spin the series?

> 
> Signed-off-by: Deepak Kodihalli <dkodihalli at nvidia.com>
> Signed-off-by: Ed Tanous <etanous at nvidia.com>
> Signed-off-by: Willie Thai <wthai at nvidia.com>
> ---
>  arch/arm/dts/ast2600-gb200nvl-bmc-nvidia.dts | 34 ++++++--------------
>  1 file changed, 10 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/dts/ast2600-gb200nvl-bmc-nvidia.dts b/arch/arm/dts/ast2600-gb200nvl-bmc-nvidia.dts
> index beac18cfcb..1bed579c1e 100644
> --- a/arch/arm/dts/ast2600-gb200nvl-bmc-nvidia.dts
> +++ b/arch/arm/dts/ast2600-gb200nvl-bmc-nvidia.dts
> @@ -46,8 +46,6 @@
>  
>  &sdrammc {
>         clock-frequency = <400000000>;
> -       aspeed,ecc-enabled;
> -       aspeed,ecc-size-mb = <0>;

This change isn't mentioned in the commit message. I expect it should
be a third patch with its own justification?

Andrew


More information about the openbmc mailing list