[PATCH linux dev-6.6] usb: typec: tcpm: Add support for parsing pd-revision DT property
Andrew Jeffery
andrew at codeconstruct.com.au
Fri May 16 10:59:12 AEST 2025
Hi Cosmo,
On Tue, 2025-05-13 at 21:53 +0800, Cosmo Chou wrote:
> From: Amit Sunil Dhamne <amitsd at google.com>
>
> Add support for parsing "pd-revision" DT property in TCPM and store PD
> revision and version supported by the Type-C connnector.
>
> It should be noted that the PD revision is the maximum possible revision
> supported by the port. This is different from the 2 bit revision set in
> PD msg headers. The purpose of the 2 bit revision value is to negotiate
> between Rev 2.X & 3.X spec rev as part of contract negotiation, while
> this is used for Get_Revision AMS after a contract is in place.
>
> Signed-off-by: Amit Sunil Dhamne <amitsd at google.com>
> Reviewed-by: Badhri Jagan Sridharan <badhri at google.com>
> Link: https://lore.kernel.org/r/20241210-get_rev_upstream-v2-2-d0094e52d48f@google.com
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 46 +++++++++++++++++++++++++++++++++--
> 1 file changed, 44 insertions(+), 2 deletions(-)
I briefly looked at directly backporting this to dev-6.6 from upstream
(8ecf60c3b3d4), but doing so generated conflicts. Did you find the
same? If so, please add a short note about what you fixed to the
trailer as well as your S-o-b tag, e.g.
...
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
[Cosmo: Changed <fix summary> to resolve merge conflcts]
Signed-off-by: <Your contact details>
Patch reports fuzz when I apply this to the tip of dev-6.6, which is
currently 5a4c98323b01 ("Merge tag 'v6.6.90' into for/openbmc/dev-
6.6"). Can you address that and re-send?
Cheers,
Andrew
More information about the openbmc
mailing list