[PATCH 2/4] net: phy: marvell: Allow targets to skip MII RX/TX errata

[Timothy Pearson]

----- Original Message -----
> From: "Paul Fertser" <fercerpav at gmail.com>
> To: "Timothy Pearson" <tpearson at raptorengineering.com>
> Cc: "openbmc" <openbmc at lists.ozlabs.org>
> Sent: Friday, March 21, 2025 6:21:30 PM
> Subject: Re: [PATCH 2/4] net: phy: marvell: Allow targets to skip MII RX/TX errata

> On Fri, Mar 21, 2025 at 08:43:12PM +0300, Paul Fertser wrote:
>> On Fri, Mar 21, 2025 at 11:30:04AM -0500, Timothy Pearson wrote:
>> > Upstream-Status: Pending
>> 
>> Pending what exactly and why? I guess you're supposed to send your
>> series upstream (to Linux devs) first, then after they're accepted you
>> can ask for backporting them to OpenBMC tree. There're exceptions but
>> you need to provide a rather convincing reason for that I guess. I'm
>> not saying that in any official capacity, just as a sidenote, Joel
>> will clarify if I'm wrong.
> 
> Huh, it wasn't at all obvious to me that your patches were meant for
> U-boot, not Linux, sorry (and you didn't specify that in the
> subject). There slightly different rules apply, but in general my
> comments should all be still relevant. Overall impression I got is
> that you're adding a bunch of hacks and that most things about them
> would need to be heavily reworked to become digestible for upstream. I
> hope more experienced developers will correct me if I'm wrong here.

No problem, I understand.  We're working with the customer to get to a point where these three patches will be dropped from the series, and only a v2 of the final Cronos board addition patch will be retained.  This platform was not designed by us, and that is where some of the constraints are coming from, but I will make sure the future patch set doesn't touch common U-boot code.

I am assuming that new OpenBMC platforms can be merged into the U-boot tree here vs. upstream U-boot, as upstream doesn't fully support the ASpeed device?  When I attempted to apply and test to upstream, there was a lot of missing code and it wasn't clear at all that the result would ever be bootable on typical OpenBMC hardware designs.

Thanks!