[PATCH 2/4] net: phy: marvell: Allow targets to skip MII RX/TX errata

[Paul Fertser]

On Fri, Mar 21, 2025 at 11:30:04AM -0500, Timothy Pearson wrote:
>  application

A rather uninformative commit message again.

> Upstream-Status: Pending

Pending what exactly and why? I guess you're supposed to send your
series upstream (to Linux devs) first, then after they're accepted you
can ask for backporting them to OpenBMC tree. There're exceptions but
you need to provide a rather convincing reason for that I guess. I'm
not saying that in any official capacity, just as a sidenote, Joel
will clarify if I'm wrong.

> +if PHY_MARVELL
> +
> +config PHY_MARVELL_APPLY_MII_RXTX_ERRATA
> +	bool
> +	default n
> +
> +endif # PHY_MARVELL

This doesn't seem to be the right approach at all. If it needs to be
specified per board, you need to add it to Device Tree schema and
those Device Tree board files that are affected.

> +		/* Per the vendor, certain Marvell devices will not function if
> +		 * the RGMII TX/RX delay registers are modified.  If an
> +		 * affected design has been selected, do not write the
> +		 * RX/TX delay registers.
> +		 */

This doesn't say much. Please reference the actual errata document
number or cite its text or find some other way to explain which
devices are affected how. Proper implementation depends a lot on those
details.