[PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
kernel test robot
lkp at intel.com
Tue Mar 4 04:41:01 AEDT 2025
Hi Eason,
kernel test robot noticed the following build errors:
[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on linus/master v6.14-rc5 next-20250303]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Eason-Yang/dt-bindings-iio-adc-add-NCT7201-ADCs/20250221-171244
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20250221090918.1487689-3-j2anfernee%40gmail.com
patch subject: [PATCH v4 2/2] iio: adc: add support for Nuvoton NCT7201
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250304/202503040154.I5tA9gE9-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250304/202503040154.I5tA9gE9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503040154.I5tA9gE9-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/iio/adc/nct7201.c:212:10: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
212 | *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
| ^
drivers/iio/adc/nct7201.c:256:9: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
256 | *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
| ^
>> drivers/iio/adc/nct7201.c:278:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
278 | FIELD_PREP(NCT7201_REG_VIN_MASK, val));
| ^
3 errors generated.
vim +/FIELD_GET +212 drivers/iio/adc/nct7201.c
192
193 static int nct7201_read_raw(struct iio_dev *indio_dev,
194 struct iio_chan_spec const *chan,
195 int *val, int *val2, long mask)
196 {
197 u16 volt;
198 unsigned int value;
199 int err;
200 struct nct7201_chip_info *chip = iio_priv(indio_dev);
201
202 if (chan->type != IIO_VOLTAGE)
203 return -EOPNOTSUPP;
204
205 guard(mutex)(&chip->access_lock);
206 switch (mask) {
207 case IIO_CHAN_INFO_RAW:
208 err = regmap_read(chip->regmap16, NCT7201_REG_VIN(chan->address), &value);
209 if (err < 0)
210 return err;
211 volt = value;
> 212 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
213 return IIO_VAL_INT;
214 case IIO_CHAN_INFO_SCALE:
215 /* From the datasheet, we have to multiply by 0.0004995 */
216 *val = 0;
217 *val2 = 499500;
218 return IIO_VAL_INT_PLUS_NANO;
219 default:
220 return -EINVAL;
221 }
222 }
223
224 static int nct7201_read_event_value(struct iio_dev *indio_dev,
225 const struct iio_chan_spec *chan,
226 enum iio_event_type type,
227 enum iio_event_direction dir,
228 enum iio_event_info info,
229 int *val, int *val2)
230 {
231 struct nct7201_chip_info *chip = iio_priv(indio_dev);
232 u16 volt;
233 unsigned int value;
234 int err;
235
236 if (chan->type != IIO_VOLTAGE)
237 return -EOPNOTSUPP;
238
239 if (info != IIO_EV_INFO_VALUE)
240 return -EINVAL;
241
242 if (dir == IIO_EV_DIR_FALLING) {
243 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
244 &value);
245 if (err < 0)
246 return err;
247 volt = value;
248 } else {
249 err = regmap_read(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
250 &value);
251 if (err < 0)
252 return err;
253 volt = value;
254 }
255
256 *val = FIELD_GET(NCT7201_REG_VIN_MASK, volt);
257
258 return IIO_VAL_INT;
259 }
260
261 static int nct7201_write_event_value(struct iio_dev *indio_dev,
262 const struct iio_chan_spec *chan,
263 enum iio_event_type type,
264 enum iio_event_direction dir,
265 enum iio_event_info info,
266 int val, int val2)
267 {
268 struct nct7201_chip_info *chip = iio_priv(indio_dev);
269
270 if (chan->type != IIO_VOLTAGE)
271 return -EOPNOTSUPP;
272
273 if (info != IIO_EV_INFO_VALUE)
274 return -EOPNOTSUPP;
275
276 if (dir == IIO_EV_DIR_FALLING)
277 regmap_write(chip->regmap16, NCT7201_REG_VIN_LOW_LIMIT(chan->address),
> 278 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
279 else
280 regmap_write(chip->regmap16, NCT7201_REG_VIN_HIGH_LIMIT(chan->address),
281 FIELD_PREP(NCT7201_REG_VIN_MASK, val));
282
283 return 0;
284 }
285
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the openbmc
mailing list