回覆: [PATCH 5/7] ARM: dts: aspeed-g6: Add PCIe RC node
Bjorn Helgaas
helgaas at kernel.org
Wed Jun 25 01:28:14 AEST 2025
On Fri, Jun 20, 2025 at 05:24:39AM +0000, Jacky Chou wrote:
> > > + resets = <&syscon ASPEED_RESET_H2X>,
> > > + <&syscon ASPEED_RESET_PCIE_RC_O>;
> > > + reset-names = "h2x", "perst";
> >
> > PERST# is clearly a per-Root Port item since it's a signal on the
> > PCIe connector. Can you separate this and any other per-Root Port
> > things into a Root Port stanza to leave open the possibility of
> > future hardware that supports multiple Root Ports in the RC?
>
> The PCIe RC that designed by us is only one root port.
Yes. But this driver may be used in the future for other RCs that
include more than one Root Port, and it would be good if that didn't
require structural changes to the DT. Also, there are RCs from other
vendors that include more than one Root Port, and I'd like all the DTs
and drivers to have similar structure.
Bjorn
More information about the openbmc
mailing list