[PATCH net-next v7 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family
Yanteng Si
si.yanteng at linux.dev
Tue Jan 14 21:29:47 AEDT 2025
在 2025/1/14 10:21, Paul Menzel 写道:
> Dear Andrew,
>
>
> Thank you for your quick reply.
>
>
> Am 14.01.25 um 21:16 schrieb Andrew Lunn:
>>>> +#define NVT_MISCR_RMII BIT(0)
>>>> +
>>>> +/* 2000ps is mapped to 0x0 ~ 0xF */
>>>
>>> Excuse my ignorance: What is ps?
>>
>> picoseconds. An RGMII link needs a 2ns delay between the clock line
>> and the data lines. Some MACs allow you to tune the delay they can
>> insert, in this case in steps of 2ns / 16.
>
> Thank you for the clarification. Maybe it’s my English, but I didn’t
> deduce this from how the comment is worded. I do not have a better idea
> either.
Hmmm, how about:
2000 ps is xxxx
I checked the kernel code and it looks like
folks usually put a space between the number
and the unit.
I looked into the rules of a bunch of publishers
again. It seems like there's a rule about putting
a space between a number and a unit, but when the
unit is a symbol, that's an exception:
space:
10 kg
10 ℃
10 h
no space:
22°36′48″N, 114°10′10″E
Thanks,
Yanteng
More information about the openbmc
mailing list