[PATCH linux dev-6.6 3/3] net: mctp: usb: Port for kernel 6.6

[Jeremy Kerr]

Hi Santosh,

> --- a/drivers/net/mctp/mctp-usb.c
> +++ b/drivers/net/mctp/mctp-usb.c
> @@ -48,16 +48,17 @@ static void mctp_usb_out_complete(struct urb *urb)
>         case -ECONNRESET:
>         case -ESHUTDOWN:
>         case -EPROTO:
> -               dev_dstats_tx_dropped(netdev);
> +        netdev->stats.tx_dropped++;

Some weird indenting happening here (and with most of the other
additions too).

If we don't want to use dstats, we should also remove

    dev->pcpu_stat_type = NETDEV_PCPU_STAT_DSTATS;

Have you checked that the stats look correct in your backport?

> @@ -340,7 +342,7 @@ static int mctp_usb_probe(struct usb_interface *intf,
>  
>         INIT_DELAYED_WORK(&dev->rx_retry_work, mctp_usb_rx_retry_work);
>  
> -       rc = mctp_register_netdev(netdev, NULL, MCTP_PHYS_BINDING_USB);
> +       rc = mctp_register_netdev(netdev, NULL);
>         if (rc)
>                 goto err_free_urbs;

Alternatively, we could consider backporting 580db513b4a9 ("net: mctp:
Expose transport binding identifier via IFLA attribute") too. This would
be user-visible, as we would now have an new IFLA_MCTP_PHYS_BINDING
attribute on netlink update messages, but that should be entirely
backward-compatible for applications.

Cheers,


Jeremy