[PATCH v3 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC
Joey Lu
a0987203069 at gmail.com
Wed Nov 20 19:39:52 AEDT 2024
Dear Rob,
Thank you for your reply.
Rob Herring 於 11/20/2024 2:12 AM 寫道:
> On Mon, Nov 18, 2024 at 04:27:05PM +0800, Joey Lu wrote:
>> Create initial schema for Nuvoton MA35 family Gigabit MAC.
>>
>> Signed-off-by: Joey Lu<a0987203069 at gmail.com>
>> ---
>> .../bindings/net/nuvoton,ma35d1-dwmac.yaml | 173 ++++++++++++++++++
>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 +
>> 2 files changed, 174 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml b/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
>> new file mode 100644
>> index 000000000000..92cbbcc72f2b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/nuvoton,ma35d1-dwmac.yaml
>> @@ -0,0 +1,173 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:http://devicetree.org/schemas/net/nuvoton,ma35d1-dwmac.yaml#
>> +$schema:http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Nuvoton DWMAC glue layer controller
>> +
>> +maintainers:
>> + - Joey Lu<yclu4 at nuvoton.com>
>> +
>> +description:
>> + Nuvoton 10/100/1000Mbps Gigabit Ethernet MAC Controller is based on
>> + Synopsys DesignWare MAC (version 3.73a).
>> +
>> +# We need a select here so we don't match all nodes with 'snps,dwmac'
> You mean snps,dwmac-3.70a?
I found that the yaml can pass |dt_binding_check| without |select|. I
will drop these lines.
>> +select:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - nuvoton,ma35d1-dwmac
>> + required:
>> + - compatible
>> +
>> +allOf:
>> + - $ref: snps,dwmac.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
> oneOf is not correct. I think you wanted 'items'.
I will fix it.
>> + - enum:
>> + - nuvoton,ma35d1-dwmac
>> + - const: snps,dwmac-3.70a
> But you said above the h/w is 3.73a.
>
> Really, I'd prefer to just drop this because it's not useful on its own.
> But the driver does check for snps,dwmac-3.70a. All those
> of_device_is_compatible() calls in the driver should really be replaced
> with static match data structs.
Yes, I will drop it.
>> +
>> + reg:
>> + description:
>> + Register range should be one of the GMAC interface.
> Need to define how many entries and what they are if more than 1.
This will be fixed.
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + clocks:
>> + items:
>> + - description: MAC clock
>> + - description: PTP clock
>> +
>> + clock-names:
>> + items:
>> + - const: stmmaceth
>> + - const: ptp_ref
>> +
>> + nuvoton,sys:
>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + items:
>> + - items:
>> + - description: phandle to access syscon registers.
>> + - description: GMAC interface ID.
>> + enum:
>> + - 0
>> + - 1
>> + description:
>> + A phandle to the syscon with one argument that configures system registers
>> + for MA35D1's two GMACs. The argument specifies the GMAC interface ID.
>> +
>> + resets:
>> + maxItems: 1
>> +
>> + reset-names:
>> + items:
>> + - const: stmmaceth
>> +
>> + phy-mode:
>> + enum:
>> + - rmii
>> + - rgmii
>> + - rgmii-id
>> + - rgmii-txid
>> + - rgmii-rxid
>> +
>> + phy-handle:
>> + $ref: /schemas/types.yaml#/definitions/phandle
> The type is already defined. Drop.
I will drop it.
>> + description:
>> + Specifies a reference to a node representing a PHY device.
>> +
>> + tx-internal-delay-ps:
>> + enum: [0, 2000]
>> + default: 0
>> + description:
>> + RGMII TX path delay used only when PHY operates in RGMII mode with
>> + internal delay (phy-mode is 'rgmii-id' or 'rgmii-txid') in pico-seconds.
>> +
>> + rx-internal-delay-ps:
>> + enum: [0, 2000]
>> + default: 0
>> + description:
>> + RGMII RX path delay used only when PHY operates in RGMII mode with
>> + internal delay (phy-mode is 'rgmii-id' or 'rgmii-rxid') in pico-seconds.
>> +
>> + mdio:
>> + $ref: /schemas/net/mdio.yaml#
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - interrupt-names
>> + - clocks
>> + - clock-names
>> + - nuvoton,sys
>> + - resets
>> + - reset-names
>> + - phy-mode
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h>
>> + #include <dt-bindings/reset/nuvoton,ma35d1-reset.h>
>> + //Example 1
> Not a useful comment.
I will drop it.
>> + gmac0: ethernet at 40120000 {
> Drop unused labels.
All unused labels will be dropped.
>> + compatible = "nuvoton,ma35d1-dwmac";
>> + reg = <0x0 0x40120000 0x0 0x10000>;
>> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "macirq";
>> + clocks = <&clk EMAC0_GATE>, <&clk EPLL_DIV8>;
>> + clock-names = "stmmaceth", "ptp_ref";
>> +
>> + nuvoton,sys = <&sys 0>;
>> + resets = <&sys MA35D1_RESET_GMAC0>;
>> + reset-names = "stmmaceth";
>> +
>> + phy-mode = "rgmii-id";
>> + phy-handle = <ð_phy0>;
>> + mdio0: mdio {
>> + compatible = "snps,dwmac-mdio";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + eth_phy0: ethernet-phy at 0 {
>> + reg = <0>;
>> + };
>> + };
>> + };
>> +
>> + - |
>> + //Example 2
>> + gmac1: ethernet at 40130000 {
> Drop the example. It's almost the same as the first one.
I will drop it.
>> + compatible = "nuvoton,ma35d1-dwmac";
>> + reg = <0x0 0x40130000 0x0 0x10000>;
>> + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "macirq";
>> + clocks = <&clk EMAC1_GATE>, <&clk EPLL_DIV8>;
>> + clock-names = "stmmaceth", "ptp_ref";
>> +
>> + nuvoton,sys = <&sys 1>;
>> + resets = <&sys MA35D1_RESET_GMAC1>;
>> + reset-names = "stmmaceth";
>> +
>> + phy-mode = "rmii";
>> + phy-handle = <ð_phy1>;
>> + mdio1: mdio {
>> + compatible = "snps,dwmac-mdio";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + eth_phy1: ethernet-phy at 1 {
>> + reg = <1>;
>> + };
>> + };
>> + };
>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> index 4e2ba1bf788c..aecdb3d37b53 100644
>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> @@ -66,6 +66,7 @@ properties:
>> - ingenic,x2000-mac
>> - loongson,ls2k-dwmac
>> - loongson,ls7a-dwmac
>> + - nuvoton,ma35d1-dwmac
>> - qcom,qcs404-ethqos
>> - qcom,sa8775p-ethqos
>> - qcom,sc8280xp-ethqos
>> --
>> 2.34.1
Thanks!
BR,
Joey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20241120/eae71cae/attachment-0001.htm>
More information about the openbmc
mailing list