[PATCH 1/3] dt-bindings: net: nuvoton: Add schema for Nuvoton MA35 family GMAC

[Andrew Lunn]

On Thu, Nov 07, 2024 at 06:31:26PM +0800, Joey Lu wrote:
> Dear Andrew,
> 
> Thank you for your reply.
> 
> Andrew Lunn 於 11/7/2024 2:13 AM 寫道:
> > > +  phy-mode:
> > > +    enum:
> > > +      - rmii
> > > +      - rgmii-id
> > The phy-mode deepened on the board design. All four rgmii values are
> > valid.
> I will add them.
> > > +
> > > +  tx_delay:
> > > +    maxItems: 1
> > > +    description:
> > > +      Control transmit clock path delay in nanoseconds.
> > > +
> > > +  rx_delay:
> > > +    maxItems: 1
> > > +    description:
> > > +      Control receive clock path delay in nanoseconds.
> > If you absolutely really need these, keep them, but i suggest you drop
> > them. They just cause confusion, when ideally we want the PHY to be
> > adding RGMII delays, not the MAC.
> > 
> > If you do need them, then they should be in pS.
> 
> I will fix it.
> 
> We have customers who use a fixed link instead of a PHY, so these properties
> may be necessary.

That is a legitimate use case which can require the MAC to add delays,
but i generally try to get the switch on the other end to add the
delays, just to keep with the uniform setup.

Also, please take a look at ethernet-controller.yaml, these should be
called rx-internal-delay-ps & tx-internal-delay-ps.

	Andrew