[PATCH v6 2/2] hwmon: Add driver for I2C chip Nuvoton NCT7363Y

Ban Feng baneric926 at gmail.com
Mon Nov 4 19:20:25 AEDT 2024


On Tue, Oct 22, 2024 at 11:14 PM Guenter Roeck <linux at roeck-us.net> wrote:
>
> On 10/22/24 00:20, Christophe JAILLET wrote:
> [ ... ]
> >> +    hwmon_dev =
> >> +        devm_hwmon_device_register_with_info(dev, client->name, data,
> >> +                             &nct7363_chip_info, NULL);
> >
> > return devm_hwmon_device_register_with_info()?
> >
>
> No, because the function needs to return an integer, not a pointer.
> And
>         return PTR_ERR_OR_ZERO(devm_hwmon_device_register_with_info(...));
> would look a bit awkward.
>
> Guenter
>

Hi Guenter and Christophe,

I'll keep following this driver and check with these suggestions.

Thanks,
Ban


More information about the openbmc mailing list