[PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC

[Kelly Hung(洪嘉莉)]

Hi, Krzysztof,

I have already executed
 - `git log --oneline -- DIRECTORY_OR_FILE`
 - do scripts/get_maintainers.pl
I tried correcting subject prefix and resent on 2/22.
According this document: https://github.com/openbmc/docs/blob/master/kernel-development.md.
"You should feel welcome to cc the OpenBMC list when sending upstream, so other kernel developers can provide input where appropriate."
So, I also -cc to openbmc at lists.ozlabs.org.

Thanks for review.

Best Regards
Kelly
-----Original Message-----
From: Krzysztof Kozlowski <krzk at kernel.org>
Sent: Thursday, February 1, 2024 5:24 PM
To: Kelly Hung <ppighouse at gmail.com>; openbmc at lists.ozlabs.org
Cc: Kelly Hung(洪嘉莉) <Kelly_Hung at asus.com>
Subject: Re: [PATCH] ARM: dts: aspeed: asus: Add ASUS X4TF BMC

External email : Ensure your email is secure before opening links and attachments.

On 30/01/2024 10:04, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <Kelly_Hung at asus.com>
> ---
>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>  1 file changed, 1 insertion(+)

I assume this is not a submission to mainline Linux kernel thus it is fine.

However if by any chance it is submission to mainline Linux kernel, then:

Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.


Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Tools like b4 or scripts_getmaintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, use mainline), work on fork of kernel (don't, use
mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof


<p></p>
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.

For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================