[PATCH 1/3] dt-bindings: pinctrl: aspeed: Use block syntax for function and groups
Andrew Jeffery
andrew at codeconstruct.com.au
Mon Jun 17 17:21:00 AEST 2024
Hi Linus,
On Wed, 2024-06-05 at 10:17 +0930, Andrew Jeffery wrote:
> On Tue, 2024-06-04 at 14:27 -0500, Rob Herring wrote:
> > On Fri, May 31, 2024 at 12:32:47PM +0930, Andrew Jeffery wrote:
> > > The expansion makes the documents a lot longer, but it's easier to
> > > review changes to functions and groups when we're not having to deal
> > > with line wrapping.
> >
> > Do you really expect to be updating this frequently? I would leave it
> > as-is, but whatever you decide.
>
> I don't expect to be updating it frequently. However it's happened
> occasionally in the past and the diff chaos irks me. So I prefer we
> explode it.
>
> >
> > > Signed-off-by: Andrew Jeffery <andrew at codeconstruct.com.au>
> > > ---
> >
> > Acked-by: Rob Herring (Arm) <robh at kernel.org>
>
> Thanks.
>
Are you okay to apply these (I see they're not yet in linux-pinctrl.git
for-next)? Turns out there's another concern lurking in the AST2600
RMII pin groups[1], and it would be nice if we could rework the patch
for that on top of this series.
[1]: https://lore.kernel.org/linux-gpio/20240613080725.2531580-1-potin.lai.pt@gmail.com/
Andrew
More information about the openbmc
mailing list