[linux dev-6.6 v1 2/6] dt-bindings: clock: npcm845: Add reference 25m clock property

Andrew Jeffery andrew at codeconstruct.com.au
Wed Jul 3 16:09:26 AEST 2024


On Mon, 2024-07-01 at 10:10 +0300, Tomer Maimon wrote:
> The NPCM8XX clock driver uses a 25Mhz external clock, therefore adding
> clock property.
> 
> The new required clock property does not break the NPCM8XX clock ABI
> since the NPCM8XX clock driver hasn't merged yet to the Linux vanilla.
> 
> Signed-off-by: Tomer Maimon <tmaimon77 at gmail.com>
> ---
>  arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 9 +++++----
>  arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts     | 7 +++++++

The patch subject is quite misleading - this isn't modifying the
binding at all, rather the actual devicetrees.

Has this work been sent upstream?

>  2 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index ecd171b2feba..41d345448430 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -52,6 +52,7 @@ rstc: reset-controller at f0801000 {
>  			reg = <0x0 0xf0801000 0x0 0x78>;
>  			#reset-cells = <2>;
>  			nuvoton,sysgcr = <&gcr>;
> +			clocks = <&refclk>;

Why not add `#clock-cells` here while we're at it (squash patch 3/6
into this one)?

Andrew


More information about the openbmc mailing list