[linux dev-6.6 v3 3/3] clk: npcm8xx: add clock controller

Wed Aug 28 23:09:35 AEST 2024

Hi Andrew,

Thanks for your comments,

Send V4 with fixed exceed line length.

Tomer

On Wed, 28 Aug 2024 at 04:48, Andrew Jeffery
<andrew at codeconstruct.com.au> wrote:
>
> On Tue, 2024-08-27 at 16:35 +0300, Tomer Maimon wrote:
> > Add auxiliary driver to support Nuvoton Arbel BMC NPCM8XX contains an
> > integrated clock controller which generates and supplies clocks to all
> > modules within the BMC.
> >
> > The NPCM8xx clock controller is created using the auxiliary device
> > framework and set up in the npcm reset driver since the NPCM8xx clock is
> > using the same register region.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77 at gmail.com>
> > Tested-by: Benjamin Fair <benjaminfair at google.com>
>
> So checkpatch still warns on this one, though I think whitespace is
> less of a problem.
>
> For what it's worth, here's the output I get:
>
>    Executing: ./scripts/checkpatch.pl --strict -g HEAD
>    WARNING: please write a help paragraph that fully describes the config symbol
>    #33: FILE: drivers/clk/Kconfig:328:
>    +config COMMON_CLK_NPCM8XX
>    +       tristate "Clock driver for the NPCM8XX SoC Family"
>    +       depends on ARCH_NPCM || COMPILE_TEST
>    +       help
>    +         This driver supports the clocks on the Nuvoton BMC NPCM8XX SoC Family,
>    +         all the clocks are initialized by the bootloader, so this driver
>    +         allows only reading of current settings directly from the hardware.
>    +
>
>    WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>    #57:
>    new file mode 100644
>
>    WARNING: line length of 112 exceeds 100 columns
>    #252: FILE: drivers/clk/clk-npcm8xx.c:191:
>    +       { NPCM8XX_CLKDIV1, 26, 2, "ahb", &hw_pre_clk, CLK_DIVIDER_READ_ONLY, CLK_IS_CRITICAL, NPCM8XX_CLK_AHB },
>
>    WARNING: line length of 137 exceeds 100 columns
>    #257: FILE: drivers/clk/clk-npcm8xx.c:196:
>    +       { NPCM8XX_CLKDIV1, 28, 3, "adc", &npcm8xx_pre_divs[0].hw, CLK_DIVIDER_READ_ONLY | CLK_DIVIDER_POWER_OF_TWO, 0, NPCM8XX_CLK_ADC },
>
>    WARNING: line length of 107 exceeds 100 columns
>    #259: FILE: drivers/clk/clk-npcm8xx.c:198:
>    +       { NPCM8XX_CLKDIV1, 11, 5, "mmc", &npcm8xx_muxes[2].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_MMC },
>
>    WARNING: line length of 106 exceeds 100 columns
>    #261: FILE: drivers/clk/clk-npcm8xx.c:200:
>    +       { NPCM8XX_CLKDIV1, 2, 4, "pci", &npcm8xx_muxes[7].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_PCI },
>
>    WARNING: line length of 139 exceeds 100 columns
>    #263: FILE: drivers/clk/clk-npcm8xx.c:202:
>    +       { NPCM8XX_CLKDIV2, 30, 2, "apb4", &npcm8xx_pre_divs[1].hw, CLK_DIVIDER_READ_ONLY | CLK_DIVIDER_POWER_OF_TWO, 0, NPCM8XX_CLK_APB4 },
>
>    WARNING: line length of 139 exceeds 100 columns
>    #264: FILE: drivers/clk/clk-npcm8xx.c:203:
>    +       { NPCM8XX_CLKDIV2, 28, 2, "apb3", &npcm8xx_pre_divs[1].hw, CLK_DIVIDER_READ_ONLY | CLK_DIVIDER_POWER_OF_TWO, 0, NPCM8XX_CLK_APB3 },
>
>    WARNING: line length of 139 exceeds 100 columns
>    #265: FILE: drivers/clk/clk-npcm8xx.c:204:
>    +       { NPCM8XX_CLKDIV2, 26, 2, "apb2", &npcm8xx_pre_divs[1].hw, CLK_DIVIDER_READ_ONLY | CLK_DIVIDER_POWER_OF_TWO, 0, NPCM8XX_CLK_APB2 },
>
>    WARNING: line length of 139 exceeds 100 columns
>    #266: FILE: drivers/clk/clk-npcm8xx.c:205:
>    +       { NPCM8XX_CLKDIV2, 24, 2, "apb1", &npcm8xx_pre_divs[1].hw, CLK_DIVIDER_READ_ONLY | CLK_DIVIDER_POWER_OF_TWO, 0, NPCM8XX_CLK_APB1 },
>
>    WARNING: line length of 139 exceeds 100 columns
>    #267: FILE: drivers/clk/clk-npcm8xx.c:206:
>    +       { NPCM8XX_CLKDIV2, 22, 2, "apb5", &npcm8xx_pre_divs[1].hw, CLK_DIVIDER_READ_ONLY | CLK_DIVIDER_POWER_OF_TWO, 0, NPCM8XX_CLK_APB5 },
>
>    WARNING: line length of 113 exceeds 100 columns
>    #268: FILE: drivers/clk/clk-npcm8xx.c:207:
>    +       { NPCM8XX_CLKDIV2, 16, 5, "clkout", &npcm8xx_muxes[8].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_CLKOUT },
>
>    WARNING: line length of 107 exceeds 100 columns
>    #269: FILE: drivers/clk/clk-npcm8xx.c:208:
>    +       { NPCM8XX_CLKDIV2, 13, 3, "gfx", &npcm8xx_muxes[7].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_GFX },
>
>    WARNING: line length of 112 exceeds 100 columns
>    #270: FILE: drivers/clk/clk-npcm8xx.c:209:
>    +       { NPCM8XX_CLKDIV2, 8, 5, "usb_bridge", &npcm8xx_muxes[4].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_SU },
>
>    WARNING: line length of 112 exceeds 100 columns
>    #271: FILE: drivers/clk/clk-npcm8xx.c:210:
>    +       { NPCM8XX_CLKDIV2, 4, 4, "usb_host", &npcm8xx_muxes[4].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_SU48 },
>
>    WARNING: line length of 108 exceeds 100 columns
>    #272: FILE: drivers/clk/clk-npcm8xx.c:211:
>    +       { NPCM8XX_CLKDIV2, 0, 4, "sdhc", &npcm8xx_muxes[2].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_SDHC },
>
>    WARNING: line length of 112 exceeds 100 columns
>    #274: FILE: drivers/clk/clk-npcm8xx.c:213:
>    +       { NPCM8XX_CLKDIV3, 16, 8, "spi1", &npcm8xx_pre_divs[1].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_SPI1 },
>
>    WARNING: line length of 111 exceeds 100 columns
>    #275: FILE: drivers/clk/clk-npcm8xx.c:214:
>    +       { NPCM8XX_CLKDIV3, 11, 5, "uart2", &npcm8xx_muxes[3].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_UART2 },
>
>    WARNING: line length of 111 exceeds 100 columns
>    #276: FILE: drivers/clk/clk-npcm8xx.c:215:
>    +       { NPCM8XX_CLKDIV3, 6, 5, "spi0", &npcm8xx_pre_divs[1].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_SPI0 },
>
>    WARNING: line length of 111 exceeds 100 columns
>    #277: FILE: drivers/clk/clk-npcm8xx.c:216:
>    +       { NPCM8XX_CLKDIV3, 1, 5, "spix", &npcm8xx_pre_divs[1].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_SPIX },
>
>    WARNING: line length of 106 exceeds 100 columns
>    #279: FILE: drivers/clk/clk-npcm8xx.c:218:
>    +       { NPCM8XX_CLKDIV4, 28, 4, "rg", &npcm8xx_muxes[11].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_RG },
>
>    WARNING: line length of 108 exceeds 100 columns
>    #280: FILE: drivers/clk/clk-npcm8xx.c:219:
>    +       { NPCM8XX_CLKDIV4, 12, 4, "rcp", &npcm8xx_muxes[12].hw, CLK_DIVIDER_READ_ONLY, 0, NPCM8XX_CLK_RCP },
>
>    WARNING: line length of 133 exceeds 100 columns
>    #282: FILE: drivers/clk/clk-npcm8xx.c:221:
>    +       { NPCM8XX_THRTL_CNT, 0, 2, "th", &npcm8xx_muxes[0].hw, CLK_DIVIDER_READ_ONLY | CLK_DIVIDER_POWER_OF_TWO, 0, NPCM8XX_CLK_TH },
>
>    WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
>    #490: FILE: drivers/clk/clk-npcm8xx.c:429:
>    +MODULE_LICENSE("GPL v2");
>
>    total: 0 errors, 24 warnings, 0 checks, 450 lines checked
>
> Andrew