[linux dev-6.6 v2 3/3] clk: npcm8xx: add clock controller

Tomer Maimon tmaimon77 at gmail.com
Tue Aug 27 23:40:37 AEST 2024


Hi Andrew,

Thanks for your comment, It sure is worth trying, I will send it to
the clock maintainer once you get NPCM8xx clock V3 and confirm it.

it is weird, it looks like the format-patch creates these trailing
whitespace errors, I don't see whitespace in the code, so I needed to
fix it manually in the patch.

What can cause adding trailing whitespace when generating patches?

Thanks,

Tomer

On Tue, 27 Aug 2024 at 05:24, Andrew Jeffery
<andrew at codeconstruct.com.au> wrote:
>
> On Mon, 2024-08-26 at 10:11 +0300, Tomer Maimon wrote:
> > Add auxiliary driver to support Nuvoton Arbel BMC NPCM8XX contains an
> > integrated clock controller which generates and supplies clocks to all
> > modules within the BMC.
> >
> > The NPCM8xx clock controller is created using the auxiliary device
> > framework and set up in the npcm reset driver since the NPCM8xx clock is
> > using the same register region.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77 at gmail.com>
> > Tested-by: Benjamin Fair <benjaminfair at google.com>
>
> Just a note that this patch generates a bunch of checkpatch warnings.
> Is this something you've considered? I ask because it's best to try
> remove all reasons for Stephen not to apply your series...
>
> Andrew


More information about the openbmc mailing list