[PATCH linux dev 6.11 1/2] hwmon driver sq52205
Guenter Roeck
linux at roeck-us.net
Tue Aug 13 02:41:11 AEST 2024
On 8/12/24 08:42, Wenliang wrote:
> I add a hwmon driver code sq52205.c, and synchronously modify the makefile
> and Kconfig files.
> Looking forward to your reply
>
> Signed-off-by: Wenliang <wenliang202407 at 163.com>
>
I don't know what SQ52205 is (no such product is listed on the Silergy web site),
but this very much looks like a copy of the ina2xx driver. There is no public
documentation, so I can not even determine if the chip is real, much less if
it should or could be merged into the existing driver.
Please read and follow guidelines for submitting patches, including the guildelines
for submitting patches into the hardware monitoring subsystem. I am not going to
provide a detailed review since there is just too much wrong with this patch.
Either case, you might want to look into the hwmon-staging branch of
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
because it includes an almost complete rework of the ina2xx driver.
Guenter
More information about the openbmc
mailing list