[PATCH v1 7/7] i2c: npcm: fix checkpatch

Tyrone Ting warp5tw at gmail.com
Fri Aug 9 17:17:07 AEST 2024


Hi Andrew:

Andrew Jeffery <andrew at codeconstruct.com.au> 於 2024年8月9日 週五 下午2:50寫道:
>
> Hello,
>
> On Wed, 2024-08-07 at 18:02 +0800, warp5tw at gmail.com wrote:
> > From: Tyrone Ting <kfting at nuvoton.com>
> >
> > Fix checkpatch warning.
> >
> > Fixes: 48acf8292280 ("i2c: Remove redundant comparison in npcm_i2c_reg_slave")
> > Signed-off-by: Tyrone Ting <kfting at nuvoton.com>
> > ---
> >  drivers/i2c/busses/i2c-npcm7xx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
> > index 1af6a927b9c1..dbe652d628ee 100644
> > --- a/drivers/i2c/busses/i2c-npcm7xx.c
> > +++ b/drivers/i2c/busses/i2c-npcm7xx.c
> > @@ -1783,7 +1783,7 @@ static int npcm_i2c_int_master_handler(struct npcm_i2c *bus)
> >               /* reenable slave if it was enabled */
> >               if (bus->slave)
> >                       iowrite8((bus->slave->addr & 0x7F) | NPCM_I2CADDR_SAEN,
> > -                             bus->reg + NPCM_I2CADDR1);
> > +                              bus->reg + NPCM_I2CADDR1);
> >  #endif
> >               return 0;
> >       }
>
> Fixing checkpatch warnings means you need to modify the commit that
> checkpatch identified as having problems, not just add a fix-up patch
> on top.
>
> It looks like this change should be squashed into the patch before it.

Got it, thank you for your comments.

>
> Andrew
>

Regards,
Tyrone


More information about the openbmc mailing list