[PATCH linux dev-6.6 v2 1/1] ARM: dts: aspeed: system1: IBM System1 BMC update

Ninad Palsule ninad at linux.ibm.com
Tue Aug 6 00:07:21 AEST 2024


Hi Andrew,

On 8/4/24 23:18, Andrew Jeffery wrote:
> On Thu, 2024-08-01 at 09:30 -0500, Ninad Palsule wrote:
>> Updated MAX31785a pmbus based fans in the device tree.
>>
>> Signed-off-by: Ninad Palsule <ninad at linux.ibm.com>
>> ---
>>   .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 95 +++++++++++++++++++
>>   1 file changed, 95 insertions(+)
> I've applied this, not because I think it's a good idea, but because
> it's something the OpenBMC tree already supports. If that weren't the
> case then I would require that you work with upstream on the bindings
> as usual.

Thanks!


>
> That said, please now do that work with upstream to get a sensible
> binding together. The less difference we have from upstream the better.
Yes, I will start working on this.
>
> Thanks,
>
> Andrew
>
> PS: In the future, can you please try to be more descriptive in your
> patch subject than "IBM System1 BMC update"? At the very least I would
> like it to say something about fan configuration in this instance.

will do. Thanks!


Regards,

Ninad Palsule



More information about the openbmc mailing list