[PATCH v1 1/1] ARM: dts: aspeed: system1: IBM System1 BMC update

[Andrew Jeffery]

On Wed, 2024-07-31 at 16:47 -0500, Ninad Palsule wrote:
> Updated MAX31785a pmbus based fans in the device tree.
> 
> Signed-off-by: Ninad Palsule <ninad at linux.ibm.com>
> ---
>  .../dts/aspeed/aspeed-bmc-ibm-system1.dts     | 96 +++++++++++++++++++
>  1 file changed, 96 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> index f3efecc7eb8d0..f96b299d743ba 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
> @@ -764,17 +764,113 @@ regulator at 43 {
>  	};
>  };
>  
> +

This whitespace change seems unnecessary.

>  &i2c6 {
>  	status = "okay";
>  
>  	fan-controller at 52 {
>  		compatible = "maxim,max31785a";
>  		reg = <0x52>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		fan0: fan at 0 {
> +			compatible = "pmbus-fan";
> +			reg = <0>;
> +			tach-pulses = <2>;
> +			maxim,fan-rotor-input = "tach";
> +			maxim,fan-pwm-freq = <25000>;
> +			maxim,fan-dual-tach;
> +			maxim,fan-no-watchdog;
> +			maxim,fan-no-fault-ramp;
> +			maxim,fan-ramp = <2>;
> +			maxim,fan-fault-pin-mon;

Note that none of these maxim-specific properties are documented in the
upstream bindings. You will need to get that addressed either before or
in the same series as this DTS patch when you send it upstream.

Can you please fix up the whitespace and re-send this to the OpenBMC
list, with the appropriate subject prefix, and _without_ including the
upstream maintainers and lists (but still including Joel and myself)?

Please reach out if there's anything that needs clarification before
you do so.

Andrew