webui by default in openbmc images

[Ed Tanous]

On Fri, Sep 22, 2023 at 11:58 AM Andrew Geissler <geissonator at gmail.com> wrote:
>
> On Thu, Sep 21, 2023 at 12:11 PM Ed Tanous <ed at tanous.net> wrote:
>
> > The problem a while ago was that the webui is not able to build
> > offline, and completely bypasses yoctos do_fetch step, so the sources
> > aren't traceable and make the software bill of materials wrong.  What
> > exists in the OpenBMC recipe is literally just calling NPM install and
> > using the NPM registry to build the webui, which isn't able to be
> > built in an offline cluster.  That, along with issues with some users
> > proxy configurations why it was never installed by default.  I think
> > we need to take this up a level, and if we decide that we don't need
> > the defaults to be built hermetically or traced, and we don't want to
> > support devs with a weird proxy, that's fine, but it should be a
> > project level decision on that, not specifically scoped at the webui
> > as a default.
>
> Ahh, that's a good point. These issues haven't been a concern for me
> but I can see how that could affect others. I updated the commit to
> create the new image feature but to not include it by default in all
> openbmc images.

I fully support it being an image feature, and FWIW, I don't have the
problems I listed above, I just recall the issues from when I was the
phosphor-webui maintainer.

>
> https://gerrit.openbmc.org/c/openbmc/openbmc/+/66675