Proposal: Removing redundant EpochTime interface from dump entry

dhruvaraj S dhruvaraj at gmail.com
Thu Sep 21 13:22:15 AEST 2023


Hi,

In the current implementation, objects implementing the dump entry
interface implement both xyz.openbmc_project.Common.Progress (for dump
creation start time, end time, and status) and
xyz.openbmc_project.Time.Epoch (for dump creation time, which is
effectively the end time). This leads to a redundancy in specifying
the dump creation end time.

My proposed change updates the documentation of the interface,
removing the reference to xyz.openbmc_project.Time.Epoch and adding a
reference to xyz.openbmc_project.Common.Progress. This is to remove
the need for updating the creation time in multiple locations.

You can review the change here:
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/66680

Please note that this change will have an impact on any applications
that are currently reading the dump creation time from the EpochTime
interface. These applications will need to be updated to read the
creation time from the xyz.openbmc_project.Common.Progress interface
instead.
Link to the interface
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Common/Progress.interface.yaml

I would appreciate it if you could take a look at the change and
provide any feedback you have.

Thanks,
Dhruvaraj Subhashchandran


-- 
--------------
Dhruvaraj S


More information about the openbmc mailing list