[PATCH v3 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver

[Andy Shevchenko]

On Mon, Oct 2, 2023 at 8:51 PM Tomer Maimon <tmaimon77 at gmail.com> wrote:
>
> Add Nuvoton NPCM BMC sdhci-pltfm controller driver.

...

> +/*
> + * NPCM SDHC MMC host controller driver.
> + *
> + * Copyright (c) 2020 Nuvoton Technology corporation.

Shouldn't it be at least 2020,2023 ?

> + */

...

> +#include <linux/clk.h>
> +#include <linux/err.h>
> +#include <linux/io.h>
> +#include <linux/mmc/host.h>
> +#include <linux/mmc/mmc.h>

+ mod_devicetable.h

> +#include <linux/module.h>
> +#include <linux/of.h>

...

> +       pltfm_host->clk = devm_clk_get_optional(&pdev->dev, NULL);
> +       if (IS_ERR(pltfm_host->clk)) {
> +               ret = PTR_ERR(pltfm_host->clk);
> +               goto err_sdhci;
> +       }
> +
> +       ret = clk_prepare_enable(pltfm_host->clk);
> +       if (ret)
> +               goto err_sdhci;

Why not use devm_clk_get_optional_enabled()?

-- 
With Best Regards,
Andy Shevchenko