[PATCH u-boot v2019.04-aspeed-openbmc v6] board: ast2600: Add Inspur SCM V1 board

[Joel Stanley]

On Tue, 30 May 2023 at 08:40, <lintao1890 at 163.com> wrote:
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -695,7 +695,8 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>         ast2600-slt.dtb \
>         ast2600-tacoma.dtb \
>         ast2600-intel.dtb \
> -       ast2600-tacoma.dtb
> +       ast2600-tacoma.dtb \
> +       ast2600-inspur-nf5280m7.dtb

Sort these alphabetically.


> +&sdrammc {
> +       clock-frequency = <400000000>;
> +};
> +


> +&i2c1 {
> +       status = "okay";
> +       multi-master;
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c2_default>;

Please go back and read my previous review comments about the pinctrl
properties on the i2c nodes.

> +++ b/board/aspeed/ast2600_inspur/inspur.c

> +int board_late_init(void)
> +{
> +       /* TODO: add Port80 init.*/
> +       return 0;


In my previous mail I suggested creating a patch series, with the
device tree in the first patch and board file in a second.
Importantly, I suggested adding the board file with the actual content
you required so we could review it properly.

If you're not ready to add the board file content, I suggest sending
just the device tree without any of the board file content (Kconfig as
well as .c).

Cheers,

Joel