[PATCH u-boot v2019.04-aspeed-openbmc v5] board: ast2600: Add Inspur SCM V1 board

[Joel Stanley]

On Tue, 30 May 2023 at 06:33, lintao1890 <lintao1890 at 163.com> wrote:
> > +int board_late_init(void)
> >> +{
> >> +       /* Turn on SCM LED1 */
> >> +       gpio_request(ASPEED_GPIO(B, 2), "");
> >> +       gpio_direction_output(ASPEED_GPIO(B, 2), GPIO_ACTIVE_LOW);
> >
> >Are you able to do this with a gpio hog in the device tree?
> >
> >If so, we would prefer that approach as it avoids adding another
> >platform to the source tree.
> >
> >Cheers,
> >
> >Joel
>
> I will be on the board_ late_init  adding other functions ,
> this turn on led1 is only the first fill.
>
> I hope my first submission is as simple as possible,
> so I added this Turn on Led.
>
> It ( "turn on led1") will be deleted in the future.
>
> so I didn't do this in the device tree .

In this case, I recommend submitting a series with the full set of
changes you have prepared. Add the device tree in the first patch, and
a second patch with your board file. Avoid adding code that you later
delete.

Cheers,

Joel