clang-16 rollout

[Patrick Williams]

Greetings,

In a few moments I plan to merge the commit that updates our CI Docker
container from clang-15 to clang-16[1].  In my early investigation,
clang-format-16 does not format 100% identical to clang-15.  I've made a
few changes to our reference `.clang-format`[2] file that attempts to get
the results closer, but it is still not identical.  As a result, it is
quite likely that pushes to Gerrit will fail CI until the formatting is
adjusted.

I will also be pushing up to Gerrit under the 'reformat-clang-format-16'
topic[3] fixes across all repositories which:

    1. Copy the reference .clang-format from docs into the repository.
    2. Re-run clang-format on the repo.

We will need maintainers to merge these in order for CI to start passing
again.

It is also possible that clang-tidy-16 is stricter than clang-tidy-15
was.  I expect the commits in the above topic to pipe-clean this and
I'll keep an eye on CI failures to see if we need some tweaks to the
various repositories to keep clang-tidy appeased.

[1]: https://gerrit.openbmc.org/c/openbmc/openbmc-build-scripts/+/62485
[2]: https://github.com/openbmc/docs/commit/231ad0cd23ad990f46218fc82e809ee9e65930c5
[3]: https://gerrit.openbmc.org/q/status:open+topic:reformat-clang-format-16

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20230510/138d462c/attachment.sig>