[PATCH] hwmon: (peci/cputemp) Fix miscalculated DTS for SKX

Paul Menzel pmenzel at molgen.mpg.de
Tue Mar 21 20:41:55 AEDT 2023


Dear Iwona,


Am 21.03.23 um 10:04 schrieb Iwona Winiarska:
> For Skylake, DTS temperature of the CPU is reported in S10.6 format
> instead of S8.8.
> 
> Reported-by: Paul Fertser <fercerpav at gmail.com>
> Link: https://lore.kernel.org/lkml/ZBhHS7v+98NK56is@home.paul.comp/
> Signed-off-by: Iwona Winiarska <iwona.winiarska at intel.com>
> ---
>   drivers/hwmon/peci/cputemp.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/peci/cputemp.c b/drivers/hwmon/peci/cputemp.c
> index 30850a479f61..87d56f0fc888 100644
> --- a/drivers/hwmon/peci/cputemp.c
> +++ b/drivers/hwmon/peci/cputemp.c
> @@ -537,6 +537,12 @@ static const struct cpu_info cpu_hsx = {
>   	.thermal_margin_to_millidegree = &dts_eight_dot_eight_to_millidegree,
>   };
>   
> +static const struct cpu_info cpu_skx = {
> +	.reg		= &resolved_cores_reg_hsx,

This is not aligned. Why not only use one space before the equal sign?

> +	.min_peci_revision = 0x33,
> +	.thermal_margin_to_millidegree = &dts_ten_dot_six_to_millidegree,
> +};
> +
>   static const struct cpu_info cpu_icx = {
>   	.reg		= &resolved_cores_reg_icx,
>   	.min_peci_revision = 0x40,
> @@ -558,7 +564,7 @@ static const struct auxiliary_device_id peci_cputemp_ids[] = {
>   	},
>   	{
>   		.name = "peci_cpu.cputemp.skx",
> -		.driver_data = (kernel_ulong_t)&cpu_hsx,
> +		.driver_data = (kernel_ulong_t)&cpu_skx,
>   	},
>   	{
>   		.name = "peci_cpu.cputemp.icx",


Kind regards,

Paul


More information about the openbmc mailing list