[RFT PATCH 1/4] dt-bindings: Add bindings for peci-npcm

Krzysztof Kozlowski krzk at kernel.org
Sun Jun 18 17:53:44 AEST 2023


On 17/06/2023 23:21, Winiarska, Iwona wrote:
> On Sat, 2023-06-17 at 09:48 +0200, Krzysztof Kozlowski wrote:
>> On 16/06/2023 21:34, Iwona Winiarska wrote:
>>> From: Tomer Maimon <tmaimon77 at gmail.com>
>>>
>>> Add device tree bindings for the peci-npcm controller driver.
>>>
>>> Signed-off-by: Tomer Maimon <tmaimon77 at gmail.com>
>>> Signed-off-by: kfting <warp5tw at gmail.com>
>>> Co-developed-by: Iwona Winiarska <iwona.winiarska at intel.com>
>>> Signed-off-by: Iwona Winiarska <iwona.winiarska at intel.com>
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC.  It might happen, that command when run on an older
>> kernel, gives you outdated entries.  Therefore please be sure you base
>> your patches on recent Linux kernel.
>>
>> You missed at least DT list (maybe more), so this won't be tested by our
>> tools. Performing review on untested code might be a waste of time, thus
>> I will skip this patch entirely till you follow the process allowing the
>> patch to be tested.
> 
> That was the idea behind marking it as "RFT", adding a note that "I wasn't able
> to test it on a real hardware so I would like to ask for help to test it on
> Nuvoton systems." 

Which does not explain sending patch incorrect patch or patch which
automation cannot test.


> in the cover letter, and sending it exclusively to OpenBMC
> mailinglist - to avoid wasting time on review before someone has a chance to run
> it on Nuvoton hardware.


Usually such patches after receiving tested tags are immediately
applied, so in that case your patch would be applied without review and
our automation testing.

Anyway, fine, to be clear it cannot be applied:

NAK, patch is not correct

Best regards,
Krzysztof



More information about the openbmc mailing list