[PATCH v2 1/3] peci: cpu: Add Intel Sapphire Rapids support
Naresh Solanki
naresh.solanki at 9elements.com
Wed Jul 19 22:17:41 AEST 2023
Hi Paul,
On Wed, 19 Jul 2023 at 16:50, Paul Menzel <pmenzel at molgen.mpg.de> wrote:
>
> Dear Naresh,
>
>
> Thank you for the patch.
>
> Am 12.07.23 um 11:12 schrieb Naresh Solanki:
> > Add support for detection of Intel Sapphire Rapids processor based on
> > CPU family & model.
> >
> > Sapphire Rapids Xeon processors with the family set to 6 and the
> > model set to INTEL_FAM6_SAPPHIRERAPIDS_X. The data field for this entry
> > is "spr".
>
> Please add, how you tested this.
Yeah, sure. Missed adding that. Will update the same in next revision.
>
> > Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
> > Signed-off-by: Naresh Solanki <Naresh.Solanki at 9elements.com>
> > ---
> > Changes in V2:
> > - Refactored from previous patchset as seperate patch based on subsystem.
> > ---
> > drivers/peci/cpu.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/peci/cpu.c b/drivers/peci/cpu.c
> > index de4a7b3e5966..3668a908d259 100644
> > --- a/drivers/peci/cpu.c
> > +++ b/drivers/peci/cpu.c
> > @@ -318,6 +318,11 @@ static const struct peci_device_id peci_cpu_device_ids[] = {
> > .model = INTEL_FAM6_ICELAKE_X,
> > .data = "icx",
> > },
> > + { /* Sapphire Rapids Xeon */
> > + .family = 6,
> > + .model = INTEL_FAM6_SAPPHIRERAPIDS_X,
> > + .data = "spr",
> > + },
> > { /* Icelake Xeon D */
> > .family = 6,
> > .model = INTEL_FAM6_ICELAKE_D,
>
> It looks like it’s incorrectly sorted, probably due to merge conflict
> resolution?
Will move it to after Xeon D in next revision.
Thanks,
Naresh
>
>
> Kind regards,
>
> Paul
More information about the openbmc
mailing list