[PATCH linux dev-6.1 v1 1/2] dt-bindings: Add bindings for peci-npcm
Tomer Maimon
tmaimon77 at gmail.com
Mon Jul 3 00:14:46 AEST 2023
Hi Krzysztof,
This patch sends to the OpenBMC Linux kernel and not to the Linux
kernel vanilla upstream, this is why I added in the message dev-6.1
and only send it to the OpenBMC mail list, please ignore it.
https://github.com/openbmc/linux
Thanks,
Tomer
On Sun, 2 Jul 2023 at 12:30, Krzysztof Kozlowski <krzk at kernel.org> wrote:
>
> On 28/06/2023 11:04, Tomer Maimon wrote:
> > Add device tree bindings for the peci-npcm controller driver.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77 at gmail.com>
> > Signed-off-by: kfting <warp5tw at gmail.com>
> > Co-developed-by: Iwona Winiarska <iwona.winiarska at intel.com>
> > Signed-off-by: Iwona Winiarska <iwona.winiarska at intel.com>
>
> My patch tracker found it, but the commit msg suggests this is not for
> Linux. I mean, you did not intend this patch to be merged into Linux
> kernel, right? Cover letter does not explain here anything.
>
> If so, please ignore.
>
> If not and you actually added some dev-6.1 by mistake, then regular
> disclaimer follows:
>
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> You missed at least DT list (maybe more), so this won't be tested by our
> tools. Performing review on untested code might be a waste of time, thus
> I will skip this patch entirely till you follow the process allowing the
> patch to be tested.
>
> Please kindly resend and include all necessary To/Cc entries.
>
>
> The sad part is that I already said it to Iwona. I wonder if all the
> comments were ignored or something was fixed?
>
> Best regards,
> Krzysztof
>
More information about the openbmc
mailing list