[PATCH 3/4] serial: 8250: Add Aspeed UART driver
ilpo.jarvinen at linux.intel.com
Sat Feb 11 00:52:03 AEDT 2023
On Fri, 10 Feb 2023, Chia-Wei Wang wrote:
> Add the driver for Aspeed UART/VUART devices, which are 16550A
> compatible. It is an wrapper to cover the generic 16550A operation
> while exetending DMA feature for the devices.
> Signed-off-by: Chia-Wei Wang <chiawei_wang at aspeedtech.com>
> drivers/tty/serial/8250/8250_aspeed.c | 502 ++++++++++++++++++++++++++
> drivers/tty/serial/8250/Kconfig | 8 +
> drivers/tty/serial/8250/Makefile | 1 +
Before I look any further into this, could you please explain why this is
made to be entirely separate from what we have in
I quickly went through some functions and they've significant parts in
common with no variations at all in many functions and you're defines
are 1:1 too (except for the DMA buf sizes). It would seem much better to
add the missing functionality into 8250_aspeed_vuart.c rather than
creating something from scratch with large overlap with existing code.
If you intend to keep it as a separate one, you should have a rather good
justification for it.
More information about the openbmc