[PATCH] ARM: dts: aspeed: Add Supermicro X13DEM (AST2600) BMC

Ryan Sie RyanS at supermicro.com.tw
Fri Feb 10 19:14:40 AEDT 2023


Hi Joel,

Thanks for your comment.

Q1: gfx_memory will remove it

A2: We don't normally have a separate partition here, although this is something you can do.
Are you using openbmc on this board?
Q2: yes, smci special design, using openbmc on this board.

A3: These numbers look suspicious. Too many 0s?
Q3: will fix it.

A4: If you're using openbmc, consider the generic names for common GPIOs.
Q4: we using smci gpio definition.

A5: mdio1~3 issues, You can omit this if it's disabled. But it seems you use it below?
Q5: will remove it.

Ryan

-----Original Message-----
From: Joel Stanley <joel at jms.id.au> 
Sent: Tuesday, February 7, 2023 12:15 PM
To: lesly895 at gmail.com
Cc: openbmc at lists.ozlabs.org; andrew at aj.id.au; Ryan Sie - TW (HW 1) <RyanS at supermicro.com.tw>
Subject: Re: [PATCH] ARM: dts: aspeed: Add Supermicro X13DEM (AST2600) BMC

[CAUTION: External Mail]

On Thu, 2 Feb 2023 at 08:55, <lesly895 at gmail.com> wrote:
>
> From: Ryan Sie <ryans at supermicro.com.tw>
>
> Add initial version of device tree for Supermicro X13DEM (AST2600) BMC.
> X13DEM is Supermicro's next generation Hyper platform with an AST2600 BMC.
>
> Signed-off-by: Ryan Sie <ryans at supermicro.com.tw>

A good start, thanks. Can you also cc the linux-arm-kernel list for future versions?

> ---
>  arch/arm/boot/dts/Makefile                    |   1 +
>  .../boot/dts/aspeed-bmc-supermicro-x13dem.dts | 398 
> ++++++++++++++++++
>  2 files changed, 399 insertions(+)
>  create mode 100664 arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
> index 2ee9c043218b..3b89006fa008 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1623,6 +1623,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>         aspeed-bmc-quanta-q71l.dtb \
>         aspeed-bmc-quanta-s6q.dtb \
>         aspeed-bmc-supermicro-x11spi.dtb \
> +       aspeed-bmc-supermicro-x13dem.dtb \
>         aspeed-bmc-inventec-transformers.dtb \
>         aspeed-bmc-tyan-s7106.dtb \
>         aspeed-bmc-tyan-s8036.dtb \
> diff --git a/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts 
> b/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts
> new file mode 100664
> index 000000000000..7c0771904544
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-supermicro-x13dem.dts
> @@ -0,0 +1,398 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2023 
> +Supermicro Corp.
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h> #include 
> +<dt-bindings/i2c/i2c.h>
> +
> +/ {
> +       model = "AST2600 BMC";
> +       compatible = "aspeed,ast2600";

Update both of thsese to have your board name. See other boards for what to do.

> +
> +       chosen {
> +               stdout-path = &uart5;
> +               bootargs = "console=ttyS4,115200 earlyprintk";
> +       };
> +
> +       memory at 80000000 {
> +               device_type = "memory";
> +               reg = <0x80000000 0x40000000>;
> +       };
> +
> +       reserved-memory {
> +               #address-cells = <1>;
> +               #size-cells = <1>;
> +               ranges;
> +
> +               video_engine_memory: video {
> +                       size = <0x04000000>;
> +                       alignment = <0x01000000>;
> +                       compatible = "shared-dma-pool";
> +                       reusable;
> +               };
> +
> +               gfx_memory: framebuffer {

are you sure you need this?

> +                       size = <0x01000000>;
> +                       alignment = <0x01000000>;
> +                       compatible = "shared-dma-pool";
> +                       reusable;
> +               };
> +
> +       };
> +
> +       leds {
> +           compatible = "gpio-leds";
> +           powerfail {
> +               default-state = "off";
> +               gpios = <&gpio0 ASPEED_GPIO(G, 5) GPIO_ACTIVE_LOW>;
> +           };
> +       };
> +
> +       iio-hwmon {
> +               compatible = "iio-hwmon";
> +               io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
> +                       <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
> +                       <&adc1 0>, <&adc1 1>, <&adc1 2>, <&adc1 3>,
> +                       <&adc1 4>, <&adc1 5>, <&adc1 6>, <&adc1 7>;
> +       };
> +
> +       aliases {
> +               mmc0 = &emmc;
> +       };
> +
> +};
> +
> +&emmc_controller {
> +       status = "okay";
> +};
> +
> +&emmc {
> +       status = "okay";
> +
> +       non-removable;
> +       max-frequency = <100000000>;
> +       sdhci-drive-type = /bits/ 8 <3>;
> +       bus-width = <4>;
> +};
> +
> +&fmc {
> +       status = "okay";
> +       flash at 0 {
> +               status = "okay";
> +               label = "bmc";
> +               spi-max-frequency = <25000000>;
> +               spi-tx-bus-width = <1>;
> +               m25p,fast-read;
> +               partitions {
> +                       compatible = "fixed-partitions";
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +
> +                       u-boot at 0 {
> +                               reg = <0x0 0x100000>;
> +                               label = "u-boot";
> +                       };
> +                       u-boot-env at 3f0000 {
> +                               reg = <0x3f0000 0x10000>;
> +                               label = "u-boot-env";
> +                       };
> +                       u-boot-env-redund at 7f0000 {
> +                               reg = <0x7f0000 0x10000>;
> +                               label = "u-boot-env-redund";

We don't normally have a separate partition here, although this is something you can do.

Are you using openbmc on this board?

> +                       };
> +               };
> +       };
> +};
> +
> +&spi1 {
> +       status = "okay";
> +       flash at 0 {
> +               status = "okay";
> +               label = "spi1:0";
> +               spi-max-frequency = <25000000>;
> +               spi-bus-width = <1>;
> +               partitions {
> +                       compatible = "fixed-partitions";
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +                       all-bios at 0 {
> +                               label = "all_part_bios";
> +                               reg = <0x000000000 0x02000000>;

These numbers look suspicious. Too many 0s?

> +                       };
> +               };
> +       };
> +
> +};
> +
> +&spi2 {
> +       status = "disabled";
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_spi2_default &pinctrl_spi2cs1_default &pinctrl_spi2cs2_default
> +                               &pinctrl_qspi2_default>;
> +
> +       flash at 0 {
> +               status = "okay";
> +               label = "spi2:0";
> +               spi-max-frequency = <100000000>;
> +               spi-bus-width = <2>;
> +               m25p,fast-read;
> +       };
> +};
> +
> +&adc0 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default
> +               &pinctrl_adc2_default &pinctrl_adc3_default
> +               &pinctrl_adc4_default &pinctrl_adc5_default
> +               &pinctrl_adc6_default &pinctrl_adc7_default>; };
> +
> +&adc1 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default
> +               &pinctrl_adc10_default &pinctrl_adc11_default
> +               &pinctrl_adc12_default &pinctrl_adc13_default
> +               &pinctrl_adc14_default &pinctrl_adc15_default>; };
> +
> +&gpio0 {
> +       status = "okay";
> +       gpio-line-names =
> +               /*A0-A7*/       "","","","","","","","",
> +               /*B0-B7*/       "","","","","","","","",
> +               /*C0-C7*/       "","","","","","","","",
> +               /*D0-D7*/       "","","","","","","","",
> +               /*E0-E7*/       "","","","","","","","",
> +               /*F0-F7*/       "","","","","","","","",
> +               /*G0-G7*/       "","","","","","","","",
> +               /*H0-H7*/       "","NMI_N","PWRBTN_N","RST_N","","","","",

If you're using openbmc, consider the generic names for common GPIOs.

> +               /*I0-I7*/       "","","","","","","","",
> +               /*J0-J7*/       "","","","","","","","",
> +               /*K0-K7*/       "","","","","","","","",
> +               /*L0-L7*/       "","","","","","","","",
> +               /*M0-M7*/       "","","","","","","","",
> +               /*N0-N7*/       "","","","","","","","",
> +               /*O0-O7*/       "","","","","","","","",
> +               /*P0-P7*/       "","","","","","","","",
> +               /*Q0-Q7*/       "","","","","","","","",
> +               /*R0-R7*/       "","","","","","","","",
> +               /*S0-S7*/       "","","","","PWROK_IN","","","",
> +               /*T0-T7*/       "","","","","","","","",
> +               /*U0-U7*/       "","","","","","","","",
> +               /*V0-V7*/       "","","","","","","","",
> +               /*W0-W7*/       "","","","","","","","",
> +               /*X0-X7*/       "","BIOS_CMP_IN","","","","","","",
> +               /*Y0-Y7*/       "","","","","","","","",
> +               /*Z0-Z7*/       "","","PWRBTN_IN","","","","","";
> +};
> +
> +&gpio1 {
> +       status = "disabled";
> +};
> +
> +&sgpiom0 {
> +       status = "disabled";
> +       gpio-line-names =
> +               /* SGPIO output lines */
> +               /*OA0-OA7*/     "","","","","","","","",
> +               /*OB0-OB7*/     "","","","","","","","",
> +               /*OC0-OC7*/     "","","","","","","","",
> +               /*OD0-OD7*/     "","","","","","","","",
> +               /*OE0-OE7*/     "","","","","","","","",
> +               /*OF0-OF7*/     "","","","","","","","",
> +               /*OG0-OG7*/     "","","","","","","","",
> +               /*OH0-OH7*/     "","","","","","","","",
> +               /*OI0-OI7*/     "","","","","","","","",
> +               /*OJ0-OJ7*/     "","","","","","","","",
> +               /*DUMMY*/       "","","","","","","","",
> +               /*DUMMY*/       "","","","","","","","",
> +
> +               /* SGPIO input lines */
> +               /*IA0-IA7*/     "","","","","","","","",
> +               /*IB0-IB7*/     "","","","","","","","",
> +               /*IC0-IC7*/     "","","","","","","","",
> +               /*ID0-ID7*/     "","","","","","","","",
> +               /*IE0-IE7*/     "","","","","","","","",
> +               /*IF0-IF7*/     "","","","","","","","",
> +               /*IG0-IG7*/     "","","","","","","","",
> +               /*IH0-IH7*/     "","","","","","","","",
> +               /*II0-II7*/     "","","","","","","","",
> +               /*IJ0-IJ7*/     "","","","","","","","";
> +};
> +
> +&kcs3 {
> +       aspeed,lpc-io-reg = <0xCA2>;
> +       status = "okay";
> +};
> +
> +&kcs4 {
> +       aspeed,lpc-io-reg = <0xCA4>;
> +       status = "okay";
> +};
> +
> +&lpc_snoop {
> +       snoop-ports = <0x80>;
> +       status = "okay";
> +};
> +
> +&uart1 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_txd1_default
> +                       &pinctrl_rxd1_default
> +                       &pinctrl_nrts1_default
> +                       &pinctrl_ndtr1_default
> +                       &pinctrl_ndsr1_default
> +                       &pinctrl_ncts1_default
> +                       &pinctrl_ndcd1_default
> +                       &pinctrl_nri1_default>; };
> +
> +&uart2 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_txd2_default
> +                       &pinctrl_rxd2_default
> +                       &pinctrl_nrts2_default
> +                       &pinctrl_ndtr2_default
> +                       &pinctrl_ndsr2_default
> +                       &pinctrl_ncts2_default
> +                       &pinctrl_ndcd2_default
> +                       &pinctrl_nri2_default>; };
> +
> +&uart3 {
> +       status = "okay";
> +};
> +
> +&uart4 {
> +       status = "okay";
> +};
> +
> +&uart5 {
> +       status = "okay";
> +};
> +
> +&uart_routing {
> +       status = "okay";
> +};
> +
> +&mdio0 {
> +       status = "okay";
> +
> +       ethphy0: ethernet-phy at 0 {
> +               compatible = "ethernet-phy-ieee802.3-c22";
> +               reg = <0>;
> +       };
> +};
> +
> +&mac0 {
> +       status = "okay";
> +
> +       phy-mode = "rgmii";
> +       phy-handle = <&ethphy0>;
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rgmii1_default>; };
> +
> +&mdio1 {
> +       status = "disabled";

You can omit this if it's disabled. But it seems you use it below?

> +
> +       ethphy1: ethernet-phy at 0 {
> +               compatible = "ethernet-phy-ieee802.3-c22";
> +               reg = <0>;
> +       };
> +};
> +
> +&mac1 {
> +       status = "disabled";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rgmii2_default>;
> +       phy-mode = "rgmii";
> +       phy-handle = <&ethphy1>;
> +};
> +
> +&mdio2 {
> +       status = "disabled";
> +
> +       ethphy2: ethernet-phy at 0 {
> +               compatible = "ethernet-phy-ieee802.3-c22";
> +               reg = <0>;
> +       };
> +};
> +
> +&mac2 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rmii3_default>;
> +       use-ncsi;
> +};
> +
> +&mdio3 {
> +       status = "disabled";
> +
> +       ethphy3: ethernet-phy at 0 {
> +               compatible = "ethernet-phy-ieee802.3-c22";
> +               reg = <0>;
> +       };
> +};
> +
> +&mac3 {
> +       status = "disabled";
> +       pinctrl-names = "default";
> +       phy-handle = <&ethphy3>;
> +       phy-mode = "rgmii";
> +
> +};
> +
> +&i2c0 {
> +       status = "okay";
> +};
> +
> +&i2c1 {
> +       status = "disabled";
> +};
> +
> +&i2c2 {
> +       multi-master;
> +       status = "okay";
> +};
> +
> +&i2c3 {
> +       status = "okay";
> +};
> +
> +&i2c4 {
> +       status = "okay";
> +       bus-frequency = <400000>;
> +};
> +
> +&i2c5 {
> +       status = "okay";
> +};
> +
> +&i2c6 {
> +       status = "okay";
> +};
> +
> +&i2c7 {
> +       status = "okay";
> +};
> +
> +&video {
> +       status = "okay";
> +       memory-region = <&video_engine_memory>; };
> +
> +&vhub {
> +       status = "okay";
> +};
> +
> +&rtc {
> +       status = "okay";
> +};
> --
> 2.25.1
>


More information about the openbmc mailing list