[PATCH v4 1/3] dt-bindings: i2c-ast2600: Add support for AST2600 I2C global controller
Ryan Chen
ryan_chen at aspeedtech.com
Thu Feb 2 16:15:16 AEDT 2023
Hello Jeremy
>
> > AST2600 I2C global register controller, add bindings document to
> > support driver of i2c global register set.
>
> [...]
>
> > +allOf:
> > + - $ref: /schemas/i2c/i2c-controller.yaml#
>
> Are you sure about this? This particular binding doesn't describe the i2c
> controller.
Due to this is i2c driver global register setting. I think I will remove this ref:
But instead add description for understanding. Is it ok?
>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - aspeed,ast2600-i2c-global
> > +
> > + reg:
> > + minItems: 1
> > + items:
> > + - description: address offset and range of bus
> > + - description: address offset and range of bus buffer
>
> Seems to be a duplicate here.
>
The same, will remove items, keep minItems:1.
Thanks
Ryan
>
>
> Jeremy
More information about the openbmc
mailing list