openbmc/telemetry: First complaint of unresponsiveness

[Ambrozewicz, Adrian]

What I mean are functional tests on target, with real BMC, board, and 
sensors.

Could you point me to examples where it's documented or done in 
automated CI for other subprojects?

Or perhaps do you meen that maintainer stalling the change until he 
makes sure it doesn't break various configurations is unacceptable? Then 
IMHO I won't aggree, as code compiled within unit tests is just one 
arch, yet alone separated from rest of the system.

Regards,
Adrian

W dniu 20.12.2023 o 16:22, Patrick Williams pisze:
> On Wed, Dec 20, 2023 at 03:18:38PM +0100, Ambrozewicz, Adrian wrote:
>>
>> Currently we've integrated proposed changes and wait for feedback from
>> automated regression test suite.
> 
> Hi Adrian,
> 
> What did you mean by this?  Commits go through CI when they are
> submitted.  I don't see any change in Gerrit for any of the 3 commits.
> 
> If you have an internal test suite you haven't contributed upstream and you
> are holding off merging commits until you run them through a private test suite,
> this is unacceptable for the open source project.
>