[PATCH linux dev-5.15] leds: pca955x: Fix i2c_smbus_read_i2c_block_data return code check

[Patrick Williams]

On Thu, Sep 29, 2022 at 02:18:48PM -0500, Eddie James wrote:
> The function returns either a negative errno or the number of bytes
> successfully read. So, only return for a negative return code.
> 
> Fixes: c9fb275212da ("leds: pca955x: Add HW blink support")
> Signed-off-by: Eddie James <eajames at linux.ibm.com>
> ---
>  drivers/leds/leds-pca955x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> index cf0a9fe20086..cba9876b1187 100644
> --- a/drivers/leds/leds-pca955x.c
> +++ b/drivers/leds/leds-pca955x.c
> @@ -689,7 +689,7 @@ static int pca955x_probe(struct i2c_client *client)
>  	err = i2c_smbus_read_i2c_block_data(client,
>  					    0x10 | (pca955x_num_input_regs(chip->bits) + 4), nls,
>  					    ls1);
> -	if (err)
> +	if (err < 0)
>  		return err;
>  
>  	for (i = 0; i < nls; ++i)
> -- 
> 2.31.1
> 

I think Potin sent this same patch 2 days ago:
    https://lore.kernel.org/openbmc/20220928085701.1822967-1-potin.lai.pt@gmail.com/

Would you mind sending a Reviewed-By / Tested-By for his patch?

-- 
Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20220929/b9cf565a/attachment-0001.sig>