phosphor-buttons multihost control

[Thang Nguyen OS]

Hi Zehra,
I think the issue of isMultiHost() has been resolved with https://github.com/openbmc/phosphor-buttons/commit/4250785723d92b6578176a2d961d47ab66e08124.

BR,
Thang Q. Nguyen

________________________________
From: openbmc <openbmc-bounces+thang=os.amperecomputing.com at lists.ozlabs.org> on behalf of Patrick Williams <patrick at stwcx.xyz>
Sent: Monday, September 26, 2022 11:27 PM
To: Naveen Moses <naveen.moses at hotmail.com>
Cc: zehra.ozdemir at inventron.com.tr <zehra.ozdemir at inventron.com.tr>; openbmc at lists.ozlabs.org <openbmc at lists.ozlabs.org>; M. Erhan Yigitbasi <erhan.yigitbasi at inventron.com.tr>; naveen.mosess at hcl.com <naveen.mosess at hcl.com>
Subject: Re: phosphor-buttons multihost control

Hi Zehra,

On Mon, Sep 26, 2022 at 07:38:39PM +0530, Naveen Moses wrote:
> The host Selector object is not strictly required. The host selector object
> check was only added to identify if the system is single host or multi host
> system based on host selector availability.
> Thanks.
>
> On Mon, Sep 26, 2022 at 12:58 PM <zehra.ozdemir at inventron.com.tr> wrote:
>
> > Hello,
> >
> >
> >
> > There is an isMultiHost() method to control to return true in case the
> > host selector object is available in button-handler.cpp of the
> > phosphor-buttons. And if it is not available, it does not return false and
> > the project gets an error. So we covered this return line with try catch
> > and it works.

Based on what Naveen wrote, it would be helpful if you could submit a
change to improve the implementation to not have this issue. I'm
surprised no one else has ran into the issues you are seeing.

> >
> > But my question is, does this host selector object has to be strictly
> > defined for the project to run properly?
> >
> >
> >
> > Thanks.
> >

--
Patrick Williams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20220926/099a2507/attachment.htm>